forgejo/routers/api/v1/repo
Gergely Nagy 9cb2aa989a
Teach activities.GetFeeds() how to avoid returning duplicates
Before explaining the fix itself, lets look at the `action` table, and
how it is populated. Data is only ever inserted into it via
`activities_model.NotifyWatchers`, which will:

- Insert a row for each activity with `UserID` set to the acting user's
  ID - this is the original activity, and is always inserted if anything
  is to be inserted at all.
- It will insert a copy of each activity with the `UserID` set to the
  repo's owner, if the owner is an Organization, and isn't the acting
  user.
- It will insert a copy of each activity for every watcher of the repo,
  as long as the watcher in question has read permission to the repo
  unit the activity is about.

This means that if a repository belongs to an organizations, for most
activities, it will have at least two rows in the table. For
repositories watched by people other than their owner, an additional row
for each watcher.

These are useful duplicates, because they record which activities are
relevant for a particular user. However, for cases where we wish to see
the activities that happen around a repository, without limiting the
results to a particular user, we're *not* interested in the duplicates
stored for the watchers and the org. We only need the originals.

And this is what this change does: it introduces an additional option to
`GetFeedsOptions`: `OnlyPerformedByActor`. When this option is set,
`activities.GetFeeds()` will only return the original activities, where
the user id and the acting user id are the same. As these are *always*
inserted, we're not missing out on any activities. We're just getting
rid of the duplicates. As this is an additional `AND` condition, it can
never introduce items that would not have been included in the result
set before, it can only reduce, not extend.

These duplicates were only affecting call sites where `RequestedRepo`
was set, but `RequestedUser` and `RequestedTeam` were not. Both of those
call sites were updated to set `OnlyPerformedByActor`. As a result,
repository RSS feeds, and the `/repos/{owner}/{repo}/activities/feeds`
API end points no longer return dupes, only the original activities.

Rather than hardcoding this behaviour into `GetFeeds()` itself, I chose
to implement it as an explicit option, for the sake of clarity.

Fixes Codeberg/Community#684, and addresses gitea#20986.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-05-09 18:33:33 +02:00
..
action.go refactor: merge ListActionTasks func to action.go file (#30811) 2024-05-05 12:15:40 +01:00
avatar.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
blob.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
branch.go Fix branch_protection api shows users/teams who has no readAccess (#30291) 2024-04-21 16:28:16 +02:00
collaborators.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
commits.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
compare.go Fix compare api swagger (#30648) 2024-04-28 15:39:00 +02:00
file.go Add an immutable tarball link to archive download headers for Nix 2024-05-03 15:21:45 -07:00
flags.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
fork.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
git_hook.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
git_ref.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
hook.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
hook_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
issue_attachment.go Catch and handle unallowed file type errors in issue attachment API (#30791) 2024-05-05 12:15:40 +01:00
issue_comment.go Do some performance optimize for issues list and view issue/pull (gitea#29515) 2024-04-08 14:47:31 +02:00
issue_comment_attachment.go Catch and handle unallowed file type errors in issue attachment API (#30791) 2024-05-05 12:15:40 +01:00
issue_dependency.go Fix missed doer (#30231) 2024-04-15 20:01:35 +02:00
issue_label.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_pin.go Fix missed doer (#30231) 2024-04-15 20:01:35 +02:00
issue_reaction.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_stopwatch.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
issue_subscription.go Add codespell support and fix a good number of typos with its help (#3270) 2024-05-09 13:49:37 +00:00
issue_tracked_time.go Fix missed doer (#30231) 2024-04-15 20:01:35 +02:00
key.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
label.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
language.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
migrate.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-05-05 08:38:16 +01:00
milestone.go remove util.OptionalBool and related functions (#29513) 2024-03-06 12:10:46 +08:00
mirror.go Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
notes.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
patch.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
pull.go Fix no edit history after editing issue's title and content (#30814) 2024-05-05 12:15:40 +01:00
pull_review.go Prevent allow/reject reviews on merged/closed PRs (#30686) 2024-04-28 15:39:01 +02:00
release.go [FEAT]Add Option to hide Release Archive links (#3139) 2024-04-24 15:15:55 +00:00
release_attachment.go Add support for API blob upload of release attachments (#29507) 2024-03-06 12:10:46 +08:00
release_tags.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
repo.go Teach activities.GetFeeds() how to avoid returning duplicates 2024-05-09 18:33:33 +02:00
repo_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
star.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
status.go Cache repository default branch commit status to reduce query on commit status table (#29444) 2024-03-11 23:36:58 +07:00
subscriber.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
tag.go Count downloads for tag archives 2024-04-08 12:51:27 +02:00
teams.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
topic.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
transfer.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
tree.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
wiki.go Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00