mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-29 20:13:27 +00:00
6433ba0ec3
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
113 lines
2.4 KiB
YAML
113 lines
2.4 KiB
YAML
linters:
|
|
enable:
|
|
- gosimple
|
|
- deadcode
|
|
- typecheck
|
|
- govet
|
|
- errcheck
|
|
- staticcheck
|
|
- unused
|
|
- structcheck
|
|
- varcheck
|
|
- golint
|
|
- dupl
|
|
#- gocyclo # The cyclomatic complexety of a lot of functions is too high, we should refactor those another time.
|
|
- gofmt
|
|
- misspell
|
|
- gocritic
|
|
enable-all: false
|
|
disable-all: true
|
|
fast: false
|
|
|
|
run:
|
|
timeout: 3m
|
|
|
|
linters-settings:
|
|
gocritic:
|
|
disabled-checks:
|
|
- ifElseChain
|
|
- singleCaseSwitch # Every time this occured in the code, there was no other way.
|
|
|
|
issues:
|
|
exclude-rules:
|
|
# Exclude some linters from running on tests files.
|
|
- path: _test\.go
|
|
linters:
|
|
- gocyclo
|
|
- errcheck
|
|
- dupl
|
|
- gosec
|
|
- unparam
|
|
- staticcheck
|
|
- path: models/migrations/v
|
|
linters:
|
|
- gocyclo
|
|
- errcheck
|
|
- dupl
|
|
- gosec
|
|
- linters:
|
|
- dupl
|
|
text: "webhook"
|
|
- linters:
|
|
- gocritic
|
|
text: "`ID' should not be capitalized"
|
|
- path: modules/templates/helper.go
|
|
linters:
|
|
- gocritic
|
|
- linters:
|
|
- unused
|
|
- deadcode
|
|
text: "swagger"
|
|
- path: contrib/pr/checkout.go
|
|
linters:
|
|
- errcheck
|
|
- path: models/issue.go
|
|
linters:
|
|
- errcheck
|
|
- path: models/migrations/
|
|
linters:
|
|
- errcheck
|
|
- path: modules/log/
|
|
linters:
|
|
- errcheck
|
|
- path: routers/routes/web.go
|
|
linters:
|
|
- dupl
|
|
- path: routers/api/v1/repo/issue_subscription.go
|
|
linters:
|
|
- dupl
|
|
- path: routers/repo/view.go
|
|
linters:
|
|
- dupl
|
|
- path: models/migrations/
|
|
linters:
|
|
- unused
|
|
- linters:
|
|
- staticcheck
|
|
text: "argument x is overwritten before first use"
|
|
- path: modules/httplib/httplib.go
|
|
linters:
|
|
- staticcheck
|
|
# Enabling this would require refactoring the methods and how they are called.
|
|
- path: models/issue_comment_list.go
|
|
linters:
|
|
- dupl
|
|
- linters:
|
|
- misspell
|
|
text: '`Unknwon` is a misspelling of `Unknown`'
|
|
- path: models/update.go
|
|
linters:
|
|
- unused
|
|
- path: cmd/dump.go
|
|
linters:
|
|
- dupl
|
|
- path: services/webhook/webhook.go
|
|
linters:
|
|
- structcheck
|
|
- text: "commentFormatting: put a space between `//` and comment text"
|
|
linters:
|
|
- gocritic
|
|
- text: "exitAfterDefer:"
|
|
linters:
|
|
- gocritic
|