fedi/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-01 04:54:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
forgejo/templates/repo/migrate
History
0ko fc0c5e80da Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 
This was [implemented](022820103d) almost 10 years ago in Gogs.

It was using `readonly` attribute instead of `disabled` on checkbox which was doing nothing. According to [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly), `readonly` attribute is not applicable to checkbox inputs. This bug was reported by mrwusel in Matrix room.
Fork page that has similar UI feature did not have this bug.

- replace `readonly` with `disabled`
- do not put info about the restriction directly into the checkbox title

### Before
![image](/attachments/6adaf1a3-6e28-416a-ac85-aa6e570e438d)

### After
![image](/attachments/3590b02b-3c83-4864-bae8-ff1a6a56b2b0)

### In other case
![image](/attachments/7f49d84d-5b3a-43a1-b09c-fb6089c1fb5e)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3786
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-16 05:51:55 +00:00
..
codebase.tmpl Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 2024-05-16 05:51:55 +00:00
forgejo.tmpl [BRANDING] add Forgejo Git Service and migration UI 2024-02-05 16:05:02 +01:00
git.tmpl Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 2024-05-16 05:51:55 +00:00
gitbucket.tmpl Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 2024-05-16 05:51:55 +00:00
gitea.tmpl Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 2024-05-16 05:51:55 +00:00
github.tmpl Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 2024-05-16 05:51:55 +00:00
gitlab.tmpl Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 2024-05-16 05:51:55 +00:00
gogs.tmpl Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 2024-05-16 05:51:55 +00:00
helper.tmpl
migrate.tmpl Migrate margin and padding helpers to tailwind (#30043) 2024-03-30 07:17:29 +01:00
migrating.tmpl Migrate gt-hidden to tw-hidden (#30046) 2024-03-30 07:17:29 +01:00
onedev.tmpl Fix and improve repo visibility checkbox when FORCE_PRIVATE is on (#3786) 2024-05-16 05:51:55 +00:00
options.tmpl Migrate gt-hidden to tw-hidden (#30046) 2024-03-30 07:17:29 +01:00