forgejo/modules/ssh
zeripath 6986e56791
Stop logging EOFs and exit(1)s in ssh handler (#20476) (#20529)
Backport #20476

The code in modules/ssh/ssh.go:sessionHandler() currently cause an error to be
logged if `gitea serv` exits with a exit(1). This logging is useless because the
accompanying stderr is not provided and in any case the exit(1) is most likely due
to permissions errors.

Further it then causes the EOF to be logged - even though this is not helpful.

This PR simply checks the errors returned and stops logging them.

In the case of misconfigurations causing `gitea serv` to fail with exit(1)
the current logging is not helpful at determining this and users should simply
review the message passed over the ssh connection.

Fix #20473

Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-07-29 02:10:42 +02:00
..
init.go Refactor SSH init code, fix directory creation for TrustedUserCAKeys file (#20299) (#20306) 2022-07-11 23:27:51 +08:00
ssh.go Stop logging EOFs and exit(1)s in ssh handler (#20476) (#20529) 2022-07-29 02:10:42 +02:00
ssh_graceful.go Refactor SSH init code, fix directory creation for TrustedUserCAKeys file (#20299) (#20306) 2022-07-11 23:27:51 +08:00