mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-22 05:36:16 +00:00
15c64122a6
- When a comment was updated or deleted and was part of an pending/ongoing review, it would have triggered a notification, such as a webhook. - This patch checks if the comment is part of a pending review and then does not fire a notification and, in the case of updating a comment, does not save the content history because this is not necessary if it is still a "draft" comment given it is a pending comment (there is no need to see my embarrassing typos). - Adds integration tests. - Resolves https://codeberg.org/forgejo/forgejo/issues/4368
137 lines
4 KiB
Go
137 lines
4 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package issue
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
notify_service "code.gitea.io/gitea/services/notify"
|
|
)
|
|
|
|
// CreateRefComment creates a commit reference comment to issue.
|
|
func CreateRefComment(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, issue *issues_model.Issue, content, commitSHA string) error {
|
|
if len(commitSHA) == 0 {
|
|
return fmt.Errorf("cannot create reference with empty commit SHA")
|
|
}
|
|
|
|
// Check if same reference from same commit has already existed.
|
|
has, err := db.GetEngine(ctx).Get(&issues_model.Comment{
|
|
Type: issues_model.CommentTypeCommitRef,
|
|
IssueID: issue.ID,
|
|
CommitSHA: commitSHA,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("check reference comment: %w", err)
|
|
} else if has {
|
|
return nil
|
|
}
|
|
|
|
_, err = issues_model.CreateComment(ctx, &issues_model.CreateCommentOptions{
|
|
Type: issues_model.CommentTypeCommitRef,
|
|
Doer: doer,
|
|
Repo: repo,
|
|
Issue: issue,
|
|
CommitSHA: commitSHA,
|
|
Content: content,
|
|
})
|
|
return err
|
|
}
|
|
|
|
// CreateIssueComment creates a plain issue comment.
|
|
func CreateIssueComment(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, issue *issues_model.Issue, content string, attachments []string) (*issues_model.Comment, error) {
|
|
// Check if doer is blocked by the poster of the issue or by the owner of the repository.
|
|
if user_model.IsBlockedMultiple(ctx, []int64{issue.PosterID, repo.OwnerID}, doer.ID) {
|
|
return nil, user_model.ErrBlockedByUser
|
|
}
|
|
|
|
comment, err := issues_model.CreateComment(ctx, &issues_model.CreateCommentOptions{
|
|
Type: issues_model.CommentTypeComment,
|
|
Doer: doer,
|
|
Repo: repo,
|
|
Issue: issue,
|
|
Content: content,
|
|
Attachments: attachments,
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
mentions, err := issues_model.FindAndUpdateIssueMentions(ctx, issue, doer, comment.Content)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
notify_service.CreateIssueComment(ctx, doer, repo, issue, comment, mentions)
|
|
|
|
return comment, nil
|
|
}
|
|
|
|
// UpdateComment updates information of comment.
|
|
func UpdateComment(ctx context.Context, c *issues_model.Comment, contentVersion int, doer *user_model.User, oldContent string) error {
|
|
if err := c.LoadReview(ctx); err != nil {
|
|
return err
|
|
}
|
|
isPartOfPendingReview := c.Review != nil && c.Review.Type == issues_model.ReviewTypePending
|
|
|
|
needsContentHistory := c.Content != oldContent && c.Type.HasContentSupport() && !isPartOfPendingReview
|
|
if needsContentHistory {
|
|
hasContentHistory, err := issues_model.HasIssueContentHistory(ctx, c.IssueID, c.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !hasContentHistory {
|
|
if err = issues_model.SaveIssueContentHistory(ctx, c.PosterID, c.IssueID, c.ID,
|
|
c.CreatedUnix, oldContent, true); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
if err := issues_model.UpdateComment(ctx, c, contentVersion, doer); err != nil {
|
|
return err
|
|
}
|
|
|
|
if needsContentHistory {
|
|
historyDate := timeutil.TimeStampNow()
|
|
if c.Issue.NoAutoTime {
|
|
historyDate = c.Issue.UpdatedUnix
|
|
}
|
|
err := issues_model.SaveIssueContentHistory(ctx, doer.ID, c.IssueID, c.ID, historyDate, c.Content, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if !isPartOfPendingReview {
|
|
notify_service.UpdateComment(ctx, doer, c, oldContent)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// DeleteComment deletes the comment
|
|
func DeleteComment(ctx context.Context, doer *user_model.User, comment *issues_model.Comment) error {
|
|
err := db.WithTx(ctx, func(ctx context.Context) error {
|
|
return issues_model.DeleteComment(ctx, comment)
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := comment.LoadReview(ctx); err != nil {
|
|
return err
|
|
}
|
|
if comment.Review == nil || comment.Review.Type != issues_model.ReviewTypePending {
|
|
notify_service.DeleteComment(ctx, doer, comment)
|
|
}
|
|
|
|
return nil
|
|
}
|