mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-14 10:34:05 +00:00
b6e81357bd
_This is a different approach to #20267, I took the liberty of adapting some parts, see below_ ## Context In some cases, a weebhook endpoint requires some kind of authentication. The usual way is by sending a static `Authorization` header, with a given token. For instance: - Matrix expects a `Bearer <token>` (already implemented, by storing the header cleartext in the metadata - which is buggy on retry #19872) - TeamCity #18667 - Gitea instances #20267 - SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this is my actual personal need :) ## Proposed solution Add a dedicated encrypt column to the webhook table (instead of storing it as meta as proposed in #20267), so that it gets available for all present and future hook types (especially the custom ones #19307). This would also solve the buggy matrix retry #19872. As a first step, I would recommend focusing on the backend logic and improve the frontend at a later stage. For now the UI is a simple `Authorization` field (which could be later customized with `Bearer` and `Basic` switches):  The header name is hard-coded, since I couldn't fine any usecase justifying otherwise. ## Questions - What do you think of this approach? @justusbunsi @Gusted @silverwind - ~~How are the migrations generated? Do I have to manually create a new file, or is there a command for that?~~ - ~~I started adding it to the API: should I complete it or should I drop it? (I don't know how much the API is actually used)~~ ## Done as well: - add a migration for the existing matrix webhooks and remove the `Authorization` logic there _Closes #19872_ Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: delvh <dev.lh@web.de> |
||
|---|---|---|
| .. | ||
| activitypub.go | ||
| admin_user.go | ||
| attachment.go | ||
| commit_status.go | ||
| cron.go | ||
| doc.go | ||
| fork.go | ||
| git_blob.go | ||
| git_hook.go | ||
| hook.go | ||
| issue.go | ||
| issue_comment.go | ||
| issue_label.go | ||
| issue_milestone.go | ||
| issue_reaction.go | ||
| issue_stopwatch.go | ||
| issue_tracked_time.go | ||
| lfs_lock.go | ||
| mirror.go | ||
| miscellaneous.go | ||
| nodeinfo.go | ||
| notifications.go | ||
| org.go | ||
| org_member.go | ||
| org_team.go | ||
| org_type.go | ||
| package.go | ||
| pull.go | ||
| pull_review.go | ||
| release.go | ||
| repo.go | ||
| repo_branch.go | ||
| repo_collaborator.go | ||
| repo_commit.go | ||
| repo_file.go | ||
| repo_key.go | ||
| repo_note.go | ||
| repo_refs.go | ||
| repo_tag.go | ||
| repo_topic.go | ||
| repo_tree.go | ||
| repo_watch.go | ||
| repo_wiki.go | ||
| settings.go | ||
| status.go | ||
| task.go | ||
| user.go | ||
| user_app.go | ||
| user_email.go | ||
| user_gpgkey.go | ||
| user_key.go | ||
