mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-11 12:40:16 +00:00
637451a45e
Fixes #26548 This PR refactors the rendering of markup links. The old code uses `strings.Replace` to change some urls while the new code uses more context to decide which link should be generated. The added tests should ensure the same output for the old and new behaviour (besides the bug). We may need to refactor the rendering a bit more to make it clear how the different helper methods render the input string. There are lots of options (resolve links / images / mentions / git hashes / emojis / ...) but you don't really know what helper uses which options. For example, we currently support images in the user description which should not be allowed I think: <details> <summary>Profile</summary> https://try.gitea.io/KN4CK3R  </details> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
110 lines
3.6 KiB
Go
110 lines
3.6 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package markup
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/markup"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
const (
|
|
AppURL = "http://localhost:3000/"
|
|
Repo = "gogits/gogs"
|
|
AppSubURL = AppURL + Repo + "/"
|
|
)
|
|
|
|
func TestRender_StandardLinks(t *testing.T) {
|
|
setting.AppURL = AppURL
|
|
setting.AppSubURL = AppSubURL
|
|
|
|
test := func(input, expected string) {
|
|
buffer, err := RenderString(&markup.RenderContext{
|
|
Ctx: git.DefaultContext,
|
|
Links: markup.Links{
|
|
Base: setting.AppSubURL,
|
|
},
|
|
}, input)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, strings.TrimSpace(expected), strings.TrimSpace(buffer))
|
|
}
|
|
|
|
test("[[https://google.com/]]",
|
|
`<p><a href="https://google.com/">https://google.com/</a></p>`)
|
|
|
|
lnk := util.URLJoin(AppSubURL, "WikiPage")
|
|
test("[[WikiPage][WikiPage]]",
|
|
`<p><a href="`+lnk+`">WikiPage</a></p>`)
|
|
}
|
|
|
|
func TestRender_Media(t *testing.T) {
|
|
setting.AppURL = AppURL
|
|
setting.AppSubURL = AppSubURL
|
|
|
|
test := func(input, expected string) {
|
|
buffer, err := RenderString(&markup.RenderContext{
|
|
Ctx: git.DefaultContext,
|
|
Links: markup.Links{
|
|
Base: setting.AppSubURL,
|
|
},
|
|
}, input)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, strings.TrimSpace(expected), strings.TrimSpace(buffer))
|
|
}
|
|
|
|
url := "../../.images/src/02/train.jpg"
|
|
result := util.URLJoin(AppSubURL, url)
|
|
|
|
test("[[file:"+url+"]]",
|
|
`<p><img src="`+result+`" alt="`+result+`" /></p>`)
|
|
|
|
// With description.
|
|
test("[[https://example.com][https://example.com/example.svg]]",
|
|
`<p><a href="https://example.com"><img src="https://example.com/example.svg" alt="https://example.com/example.svg" /></a></p>`)
|
|
test("[[https://example.com][pre https://example.com/example.svg post]]",
|
|
`<p><a href="https://example.com">pre <img src="https://example.com/example.svg" alt="https://example.com/example.svg" /> post</a></p>`)
|
|
test("[[https://example.com][https://example.com/example.mp4]]",
|
|
`<p><a href="https://example.com"><video src="https://example.com/example.mp4">https://example.com/example.mp4</video></a></p>`)
|
|
test("[[https://example.com][pre https://example.com/example.mp4 post]]",
|
|
`<p><a href="https://example.com">pre <video src="https://example.com/example.mp4">https://example.com/example.mp4</video> post</a></p>`)
|
|
|
|
// Without description.
|
|
test("[[https://example.com/example.svg]]",
|
|
`<p><img src="https://example.com/example.svg" alt="https://example.com/example.svg" /></p>`)
|
|
test("[[https://example.com/example.mp4]]",
|
|
`<p><video src="https://example.com/example.mp4">https://example.com/example.mp4</video></p>`)
|
|
}
|
|
|
|
func TestRender_Source(t *testing.T) {
|
|
setting.AppURL = AppURL
|
|
setting.AppSubURL = AppSubURL
|
|
|
|
test := func(input, expected string) {
|
|
buffer, err := RenderString(&markup.RenderContext{
|
|
Ctx: git.DefaultContext,
|
|
}, input)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, strings.TrimSpace(expected), strings.TrimSpace(buffer))
|
|
}
|
|
|
|
test(`#+begin_src go
|
|
// HelloWorld prints "Hello World"
|
|
func HelloWorld() {
|
|
fmt.Println("Hello World")
|
|
}
|
|
#+end_src
|
|
`, `<div class="src src-go">
|
|
<pre><code class="chroma language-go"><span class="c1">// HelloWorld prints "Hello World"
|
|
</span><span class="c1"></span><span class="kd">func</span> <span class="nf">HelloWorld</span><span class="p">()</span> <span class="p">{</span>
|
|
<span class="nx">fmt</span><span class="p">.</span><span class="nf">Println</span><span class="p">(</span><span class="s">"Hello World"</span><span class="p">)</span>
|
|
<span class="p">}</span></code></pre>
|
|
</div>`)
|
|
}
|