Twenty Panda 0d09acf669 fix(hook): ignore unknown push options instead of failing ... If a repository has git config --add push.pushOption submit=".sourcehut/*.yml" it failed when pushed because of the unknown submit push option. It will be ignored instead. Filtering out the push options is done in an earlier stage, when the hook command runs, before it submits the options map to the private endpoint. * move all the push options logic to modules/git/pushoptions * add 100% test coverage for modules/git/pushoptions Test coverage for the code paths from which code was moved to the modules/git/pushoptions package: * cmd/hook.go:runHookPreReceive * routers/private/hook_pre_receive.go:validatePushOptions tests/integration/git_push_test.go:TestOptionsGitPush runs through both. The test verifying the option is rejected was removed and, if added again, will fail because the option is now ignored instead of being rejected. * cmd/hook.go:runHookProcReceive * services/agit/agit.go:ProcReceive tests/integration/git_test.go: doCreateAgitFlowPull runs through both. It uses variations of AGit related push options. * cmd/hook.go:runHookPostReceive * routers/private/hook_post_receive.go:HookPostReceive tests/integration/git_test.go:doPushCreate called by TestGit/HTTP/sha1/PushCreate runs through both. Note that although it provides coverage for this code path it does not use push options. Fixes: https://codeberg.org/forgejo/forgejo/issues/3651 (cherry picked from commit 5561e80b04)		2024-07-02 20:18:33 +00:00
..
actions.go	Return responseText instead of string in some functions (#28836)	2024-01-19 10:45:23 +08:00
forgejo_actions.go	[CLI] implement forgejo-cli	2024-02-05 13:33:58 +01:00
hook.go	fix(hook): ignore unknown push options instead of failing	2024-07-02 20:18:33 +00:00
internal.go	Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687)	2023-03-29 14:32:26 +08:00
key.go	Return responseText instead of string in some functions (#28836)	2024-01-19 10:45:23 +08:00
mail.go	Return responseText instead of string in some functions (#28836)	2024-01-19 10:45:23 +08:00
manager.go	Replace interface{} with any (#25686)	2023-07-04 18:36:08 +00:00
request.go	Return responseText instead of string in some functions (#28836)	2024-01-19 10:45:23 +08:00
restore_repo.go	Fix regression: access log template, gitea manager cli command (#24838)	2023-05-22 09:38:38 +08:00
serv.go	Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687)	2023-03-29 14:32:26 +08:00