mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-26 02:00:43 +00:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
59 lines
1.6 KiB
Go
59 lines
1.6 KiB
Go
// Copyright 2024 The Forgejo Authors c/o Codeberg e.V.. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_22 //nolint
|
|
|
|
import (
|
|
"strconv"
|
|
"testing"
|
|
|
|
migration_tests "code.gitea.io/gitea/models/migrations/test"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
webhook_module "code.gitea.io/gitea/modules/webhook"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_AddPayloadVersionToHookTaskTable(t *testing.T) {
|
|
type HookTaskMigrated HookTask
|
|
|
|
// HookTask represents a hook task, as of before the migration
|
|
type HookTask struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
HookID int64 `xorm:"index"`
|
|
UUID string `xorm:"unique"`
|
|
PayloadContent string `xorm:"LONGTEXT"`
|
|
EventType webhook_module.HookEventType
|
|
IsDelivered bool
|
|
Delivered timeutil.TimeStampNano
|
|
|
|
// History info.
|
|
IsSucceed bool
|
|
RequestContent string `xorm:"LONGTEXT"`
|
|
ResponseContent string `xorm:"LONGTEXT"`
|
|
}
|
|
|
|
// Prepare and load the testing database
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(HookTask), new(HookTaskMigrated))
|
|
defer deferable()
|
|
if x == nil || t.Failed() {
|
|
return
|
|
}
|
|
|
|
assert.NoError(t, AddPayloadVersionToHookTaskTable(x))
|
|
|
|
expected := []HookTaskMigrated{}
|
|
assert.NoError(t, x.Table("hook_task_migrated").Asc("id").Find(&expected))
|
|
assert.Len(t, expected, 2)
|
|
|
|
got := []HookTaskMigrated{}
|
|
assert.NoError(t, x.Table("hook_task").Asc("id").Find(&got))
|
|
|
|
for i, expected := range expected {
|
|
expected, got := expected, got[i]
|
|
t.Run(strconv.FormatInt(expected.ID, 10), func(t *testing.T) {
|
|
assert.Equal(t, expected.PayloadVersion, got.PayloadVersion)
|
|
})
|
|
}
|
|
}
|