1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-16 14:36:22 +00:00
forgejo/web_src/js/modules/fomantic
silverwind 2072ff75e8 Add form field id generation, remove duplicated ids ()
Fixes: https://github.com/go-gitea/gitea/issues/30384

On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.

Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.

I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b)

Conflicts:
	- templates/repo/settings/options.tmpl
	  Conflict resolved by manually removing all `id` and `for`
	  attributes from elements that had `repo_name` as their id.
(cherry picked from commit a01387f5b1)
2024-04-22 07:46:30 +00:00
..
api.js
aria.md Remove fomantic checkbox module () () 2024-04-08 11:28:31 +02:00
base.js Add form field id generation, remove duplicated ids () 2024-04-22 07:46:30 +00:00
checkbox.js Add form field id generation, remove duplicated ids () 2024-04-22 07:46:30 +00:00
dropdown.js Remove jQuery .attr from the Fomantic dropdowns () 2024-03-30 07:17:31 +01:00
form.js Add form field id generation, remove duplicated ids () 2024-04-22 07:46:30 +00:00
modal.js Remove jQuery .attr from the Fomantic modal cancel buttons () 2024-03-30 07:17:30 +01:00
transition.js