mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-15 02:45:22 +00:00
2072ff75e8
Fixes: https://github.com/go-gitea/gitea/issues/30384
On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.
Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.
I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b)
Conflicts:
- templates/repo/settings/options.tmpl
Conflict resolved by manually removing all `id` and `for`
attributes from elements that had `repo_name` as their id.
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| units | ||
| webhook | ||
| actions.tmpl | ||
| branches.tmpl | ||
| collaboration.tmpl | ||
| deploy_keys.tmpl | ||
| githook_edit.tmpl | ||
| githooks.tmpl | ||
| layout_footer.tmpl | ||
| layout_head.tmpl | ||
| lfs.tmpl | ||
| lfs_file.tmpl | ||
| lfs_file_find.tmpl | ||
| lfs_locks.tmpl | ||
| lfs_pointers.tmpl | ||
| navbar.tmpl | ||
| options.tmpl | ||
| protected_branch.tmpl | ||
| push_mirror_sync_modal.tmpl | ||
| runner_edit.tmpl | ||
| secrets.tmpl | ||
| tags.tmpl | ||
| units.tmpl | ||