mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-18 03:49:46 +00:00
a64426907d
- Databases are one of the most important parts of Forgejo, every interaction with Forgejo uses the database in one way or another. Therefore, it is important to maintain the database and recognize when Forgejo is not doing well with the database. Forgejo already has the option to log *every* SQL query along with its execution time, but monitoring becomes impractical for larger instances and takes up unnecessary storage in the logs. - Add a QoL enhancement that allows instance administrators to specify a threshold value beyond which query execution time is logged as a warning in the xorm logger. The default value is a conservative five seconds to avoid this becoming a source of spam in the logs. - The use case for this patch is that with an instance the size of Codeberg, monitoring SQL logs is not very fruitful and most of them are uninteresting. Recently, in the context of persistent deadlock issues (https://codeberg.org/forgejo/forgejo/issues/220), I have noticed that certain queries hold locks on tables like comment and issue for several seconds. This patch helps to identify which queries these are and when they happen. - Added unit test. (cherry picked from commit |
||
|---|---|---|
| .. | ||
| install | ||
| paginator | ||
| common.go | ||
| consistency.go | ||
| context.go | ||
| context_committer_test.go | ||
| context_test.go | ||
| convert.go | ||
| engine.go | ||
| engine_test.go | ||
| error.go | ||
| index.go | ||
| index_test.go | ||
| iterate.go | ||
| iterate_test.go | ||
| list.go | ||
| list_test.go | ||
| log.go | ||
| main_test.go | ||
| name.go | ||
| search.go | ||
| sequence.go | ||
| sql_postgres_with_schema.go | ||