mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-01 04:54:09 +00:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
99 lines
2.4 KiB
Go
99 lines
2.4 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package base
|
|
|
|
import (
|
|
"testing"
|
|
|
|
migrations_tests "code.gitea.io/gitea/models/migrations/test"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
|
|
"xorm.io/xorm/names"
|
|
)
|
|
|
|
func Test_DropTableColumns(t *testing.T) {
|
|
x, deferable := migrations_tests.PrepareTestEnv(t, 0)
|
|
if x == nil || t.Failed() {
|
|
defer deferable()
|
|
return
|
|
}
|
|
defer deferable()
|
|
|
|
type DropTest struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
FirstColumn string
|
|
ToDropColumn string `xorm:"unique"`
|
|
AnotherColumn int64
|
|
CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
|
|
UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
|
|
}
|
|
|
|
columns := []string{
|
|
"first_column",
|
|
"to_drop_column",
|
|
"another_column",
|
|
"created_unix",
|
|
"updated_unix",
|
|
}
|
|
|
|
x.SetMapper(names.GonicMapper{})
|
|
|
|
for i := range columns {
|
|
if err := x.Sync(new(DropTest)); err != nil {
|
|
t.Errorf("unable to create DropTest table: %v", err)
|
|
return
|
|
}
|
|
|
|
sess := x.NewSession()
|
|
if err := sess.Begin(); err != nil {
|
|
sess.Close()
|
|
t.Errorf("unable to begin transaction: %v", err)
|
|
return
|
|
}
|
|
if err := DropTableColumns(sess, "drop_test", columns[i:]...); err != nil {
|
|
sess.Close()
|
|
t.Errorf("Unable to drop columns[%d:]: %s from drop_test: %v", i, columns[i:], err)
|
|
return
|
|
}
|
|
if err := sess.Commit(); err != nil {
|
|
sess.Close()
|
|
t.Errorf("unable to commit transaction: %v", err)
|
|
return
|
|
}
|
|
sess.Close()
|
|
if err := x.DropTables(new(DropTest)); err != nil {
|
|
t.Errorf("unable to drop table: %v", err)
|
|
return
|
|
}
|
|
for j := range columns[i+1:] {
|
|
if err := x.Sync(new(DropTest)); err != nil {
|
|
t.Errorf("unable to create DropTest table: %v", err)
|
|
return
|
|
}
|
|
dropcols := append([]string{columns[i]}, columns[j+i+1:]...)
|
|
sess := x.NewSession()
|
|
if err := sess.Begin(); err != nil {
|
|
sess.Close()
|
|
t.Errorf("unable to begin transaction: %v", err)
|
|
return
|
|
}
|
|
if err := DropTableColumns(sess, "drop_test", dropcols...); err != nil {
|
|
sess.Close()
|
|
t.Errorf("Unable to drop columns: %s from drop_test: %v", dropcols, err)
|
|
return
|
|
}
|
|
if err := sess.Commit(); err != nil {
|
|
sess.Close()
|
|
t.Errorf("unable to commit transaction: %v", err)
|
|
return
|
|
}
|
|
sess.Close()
|
|
if err := x.DropTables(new(DropTest)); err != nil {
|
|
t.Errorf("unable to drop table: %v", err)
|
|
return
|
|
}
|
|
}
|
|
}
|
|
}
|