forgejo/models/forgejo_migrations/v1_22
Gusted 138942c09e
[CHORE] Move test related function to own package
- Go's deadcode eliminator is quite simple, if you put a public function
in a package `aa/bb` that is used only by tests, it would still be built
if package `aa/bb` was imported. This means that if such functions use
libraries relevant only to tests that those libraries would still be
be built and increase the binary size of a Go binary.
- This is also the case with Forgejo, `models/migrations/base/tests.go`
contained functions exclusively used by tests which (skipping some steps
here) imports https://github.com/ClickHouse/clickhouse-go, which is
2MiB. The `code.gitea.io/gitea/models/migrations/base` package is
imported by `cmd/doctor` and thus the code of the clickhouse library is
also built and included in the Forgejo binary, although entirely unused
and not reachable.
- This patch moves the test-related functions to their own package, so
Go's deadcode eliminator knows not to build the test-related functions
and thus reduces the size of the Forgejo binary.
- It is not possible to move this to a `_test.go` file because Go does
not allow importing functions from such files, so any test helper
function must be in a non-test package and file.
- Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make
build`):
  - Before: 95912040 bytes (92M)
  - After: 92306888 bytes (89M)
2024-07-14 17:00:49 +02:00
..
main_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v4.go
v5.go [FEAT] Repository flags 2024-02-05 16:09:42 +01:00
v6.go models/forgejo_migrations: Gitea tables migration ID 2024-03-27 09:27:32 +01:00
v7.go models/forgejo_migrations: Gitea tables migration ID 2024-03-27 09:27:32 +01:00
v8.go Add a migration to remove SSH signatures from release notes 2024-03-26 08:09:36 +00:00
v8_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v9.go [FEAT] Configure if protected branch rule should apply to admins 2024-03-29 00:21:49 +01:00
v10.go Add back ID field to pronouns migration 2024-04-03 15:16:38 -05:00
v11.go Do not update PRs based on events that happened before they existed 2024-04-11 11:16:23 +02:00
v12.go models: reserve v11 for backporting release blocker 2024-04-11 11:13:28 +02:00