mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-24 09:27:17 +00:00
f62cd2f473
Fixes #25160. `data-source-position` of checkboxes in a task list was incorrect whenever there was YAML front matter. This would result in issue content or PR descriptions getting corrupted with random `x` or space characters when a user checked or unchecked a task.
84 lines
3.1 KiB
JavaScript
84 lines
3.1 KiB
JavaScript
import $ from 'jquery';
|
|
|
|
const preventListener = (e) => e.preventDefault();
|
|
|
|
/**
|
|
* Attaches `input` handlers to markdown rendered tasklist checkboxes in comments.
|
|
*
|
|
* When a checkbox value changes, the corresponding [ ] or [x] in the markdown string
|
|
* is set accordingly and sent to the server. On success it updates the raw-content on
|
|
* error it resets the checkbox to its original value.
|
|
*/
|
|
export function initMarkupTasklist() {
|
|
for (const el of document.querySelectorAll(`.markup[data-can-edit=true]`) || []) {
|
|
const container = el.parentNode;
|
|
const checkboxes = el.querySelectorAll(`.task-list-item input[type=checkbox]`);
|
|
|
|
for (const checkbox of checkboxes) {
|
|
if (checkbox.hasAttribute('data-editable')) {
|
|
return;
|
|
}
|
|
|
|
checkbox.setAttribute('data-editable', 'true');
|
|
checkbox.addEventListener('input', async () => {
|
|
const checkboxCharacter = checkbox.checked ? 'x' : ' ';
|
|
const position = parseInt(checkbox.getAttribute('data-source-position')) + 1;
|
|
|
|
const rawContent = container.querySelector('.raw-content');
|
|
const oldContent = rawContent.textContent;
|
|
|
|
const encoder = new TextEncoder();
|
|
const buffer = encoder.encode(oldContent);
|
|
// Indexes may fall off the ends and return undefined.
|
|
if (buffer[position - 1] !== '['.codePointAt(0) ||
|
|
buffer[position] !== ' '.codePointAt(0) && buffer[position] !== 'x'.codePointAt(0) ||
|
|
buffer[position + 1] !== ']'.codePointAt(0)) {
|
|
// Position is probably wrong. Revert and don't allow change.
|
|
checkbox.checked = !checkbox.checked;
|
|
throw new Error(`Expected position to be space or x and surrounded by brackets, but it's not: position=${position}`);
|
|
}
|
|
buffer.set(encoder.encode(checkboxCharacter), position);
|
|
const newContent = new TextDecoder().decode(buffer);
|
|
|
|
if (newContent === oldContent) {
|
|
return;
|
|
}
|
|
|
|
// Prevent further inputs until the request is done. This does not use the
|
|
// `disabled` attribute because it causes the border to flash on click.
|
|
for (const checkbox of checkboxes) {
|
|
checkbox.addEventListener('click', preventListener);
|
|
}
|
|
|
|
try {
|
|
const editContentZone = container.querySelector('.edit-content-zone');
|
|
const updateUrl = editContentZone.getAttribute('data-update-url');
|
|
const context = editContentZone.getAttribute('data-context');
|
|
|
|
await $.post(updateUrl, {
|
|
ignore_attachments: true,
|
|
_csrf: window.config.csrfToken,
|
|
content: newContent,
|
|
context
|
|
});
|
|
|
|
rawContent.textContent = newContent;
|
|
} catch (err) {
|
|
checkbox.checked = !checkbox.checked;
|
|
console.error(err);
|
|
}
|
|
|
|
// Enable input on checkboxes again
|
|
for (const checkbox of checkboxes) {
|
|
checkbox.removeEventListener('click', preventListener);
|
|
}
|
|
});
|
|
}
|
|
|
|
// Enable the checkboxes as they are initially disabled by the markdown renderer
|
|
for (const checkbox of checkboxes) {
|
|
checkbox.disabled = false;
|
|
}
|
|
}
|
|
}
|