fedi/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 00:55:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
forgejo/templates
History
wxiaoguang 027014d7de
Fix webauthn regression and improve code (#25113) 
Follow:

* #22697

There are some bugs in #22697:

* https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966
* the webauthn failure message is never shown and causes console error
* The `document.getElementById('register-button')` and
`document.getElementById('login-button')` is wrong
    * there is no such element in code
    * it causes JS error when a browser doesn't provide webauthn
    * the end user can't see the real error message

These bugs are fixed in this PR.

Other changes:

* Use simple HTML/CSS layouts, no need to use too many `gt-` patches
* Make the webauthn page have correct "page-content" layout
* The "data-webauthn-error-msg" elements are only used to provide locale
texts, so move them into a single "gt-hidden", then no need to repeat a
lot of "gt-hidden" in code
* The `{{.CsrfTokenHtml}}`  is a no-op because there is no form
* Many `hideElem('#webauthn-error')` in code is no-op because the
`webauthn-error` already has "gt-hidden" by default
* Make the tests for "URLEncodedBase64" really test with concrete cases.


Screenshots:

* Error message when webauthn fails (before, there is no error message):

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/93cf9559-d93b-4f06-9d98-0f7032d9c65b)

</details>

* Error message when webauthn is unavailable 

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/ffc0fcd9-b93b-4418-979c-c89bb627aaf2)

</details>
2023-06-07 19:20:18 +08:00
..
admin Add details summary for vertical menus in settings to allow toggling (#25098) 2023-06-07 10:49:48 +08:00
api/packages/pypi
base Remove the service worker (#25010) 2023-05-31 02:07:04 +00:00
code
custom
devtest
explore Consolidate the two review boxes into one (#24738) 2023-05-29 12:44:03 +02:00
mail
org Add details summary for vertical menus in settings to allow toggling (#25098) 2023-06-07 10:49:48 +08:00
package Consolidate the two review boxes into one (#24738) 2023-05-29 12:44:03 +02:00
projects Merge new project templates into one (#24985) 2023-05-31 08:50:18 +02:00
repo Add details summary for vertical menus in settings to allow toggling (#25098) 2023-06-07 10:49:48 +08:00
shared Show bot label next to username when rendering autor link if the user is a bot (#24943) 2023-05-26 18:58:11 +02:00
status Remove meta tags theme-color and default-theme (#24960) 2023-05-28 22:33:17 +00:00
swagger API endpoint for changing/creating/deleting multiple files (#24887) 2023-05-29 17:41:35 +08:00
user Fix webauthn regression and improve code (#25113) 2023-06-07 19:20:18 +08:00
home.tmpl
install.tmpl
post-install.tmpl