Michael Jerger
715ff0eb7f
remove unused & fix wording
2024-05-01 15:23:39 +02:00
Michael Jerger
87036ec719
Merge branch 'forgejo-federated-star' of codeberg.org:meissa/forgejo into forgejo-federated-star
2024-05-01 15:02:36 +02:00
Michael Jerger
be6e6eb96a
refactor validation
2024-05-01 15:02:27 +02:00
Earl Warren
c6cc1430a9
Merge pull request 'docs(release-notes): 7.0.2' ( #3561 ) from earl-warren/forgejo:wip-release-notes-v7.0 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3561
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-05-01 12:59:00 +00:00
erik
bbec2e2960
Fix test and add symmetry
...
This maybe was a mixup with TestActivityValidation.
We now test if the UnmarshalJSON actually threw an error.
2024-05-01 14:53:42 +02:00
Michael Jerger
4b2802a6ba
internal refactoring
2024-05-01 14:39:23 +02:00
Michael Jerger
6c7cff4f16
fix NPE
2024-05-01 14:39:09 +02:00
Earl Warren
a050b546b9
[skip ci] docs(release-notes): 7.0.2
2024-05-01 14:22:18 +02:00
Earl Warren
39732d74c9
Merge pull request 'Fix Issue watching / unwatching on the web ui' ( #3562 ) from algernon/forgejo:vogon-poetry into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3562
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: crystal <crystal@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-01 10:35:48 +00:00
Gergely Nagy
21911bfe57
Add a test case for unsubscribing from an issue
...
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-05-01 11:06:38 +02:00
Gergely Nagy
8cc5d5dc78
tests: Support creating a declarative repo without AutoInit
...
To be able to easily test cases where the repository does not have any
code, where the git repo itself is completely uninitialized, lets
support a case where the `AutoInit` property is false.
For the sake of backwards compatibility, if the option is not set either
way, it will default to `true`.
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-05-01 11:06:38 +02:00
Gergely Nagy
632a274b8f
Fix Issue watching / unwatching on the web ui
...
When subscribing or unsubscribing to/from an issue on the web ui, the
request was posted to a route handled by `repo.IssueWatch`. This
function used `ctx.Req.PostForm.Get()`, erroneously.
`request.PostForm` is *only* available if `request.ParseForm()` has been
called before it. The function in question did not do that. Under some
circumstances, something, somewhere did end up calling `ParseForm()`,
but not in every scenario.
Since we do not need to check for multiple values, the easiest fix here
is to use `ctx.Req.PostFormValue`, which will call `ParseForm()` if
necessary.
Fixes #3516 .
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-05-01 11:04:54 +02:00
Earl Warren
97ef18db65
Merge pull request 'Update dependency vue to v3.4.26' ( #3439 ) from renovate/vue-monorepo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3439
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-01 08:08:52 +00:00
Earl Warren
f11957b8f4
chore(renovate): vue patch releases can be automerged
2024-05-01 09:32:01 +02:00
Renovate Bot
bb5395cd29
Update dependency vue to v3.4.26
2024-05-01 09:30:24 +02:00
Earl Warren
0978095a37
Merge pull request 'Update ghcr.io/visualon/renovate Docker tag to v37.330.1' ( #3490 ) from renovate/ghcr.io-visualon-renovate-37.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3490
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-01 07:26:21 +00:00
Earl Warren
cf16782338
Merge pull request 'Update dependency dayjs to v1.11.11' ( #3545 ) from renovate/dayjs-1.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3545
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-05-01 07:25:09 +00:00
Earl Warren
8f93ac7e7a
Merge pull request 'feat: UI: use full screen height for displaying pdf files' ( #3434 ) from Beowulf/forgejo:full-screen-height-pdf into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3434
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-01 07:03:15 +00:00
Earl Warren
756bb7f6e1
Merge pull request 'UI: Actions: Replace runs list description semicolon' ( #3534 ) from n0toose/settings/runs-list-colon-brist into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3534
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-01 06:59:53 +00:00
Earl Warren
ee52a8e805
Merge pull request '[I18N] Fix tepository->repository typo' ( #3539 ) from proton-ab/forgejo:patch-1 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3539
Reviewed-by: Otto <otto@codeberg.org>
2024-05-01 06:58:48 +00:00
Earl Warren
a454954bd0
Merge pull request 'Update dependency vitest to v1.5.3' ( #3576 ) from renovate/vitest-monorepo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3576
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-01 06:37:39 +00:00
Renovate Bot
9a581e70a1
Update dependency vitest to v1.5.3
2024-05-01 06:03:44 +00:00
Renovate Bot
15978d4d07
Update ghcr.io/visualon/renovate Docker tag to v37.330.1
2024-05-01 06:02:32 +00:00
Earl Warren
288747c660
Merge pull request 'Fix SQL command with too many placeholders' ( #3570 ) from algernon/forgejo:many-question-marks-handle-it into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3570
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-01 05:24:08 +00:00
Gergely Nagy
33cd8446d3
Performance improvement for FindReposLastestCommitStatuses
...
If `commitstatus_service.FindReposLastestCommitStatuses` receives no
repos in its params, short-circuit, and return early, without performing
any potentially expensive work.
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-05-01 00:34:48 +02:00
Gergely Nagy
0d029ebe6d
Fix git_model.FindBranchesByRepoAndBranchName
...
When a logged in user with no repositories visits their dashboard, it will
display a search box that lists their own repositories.
This is served by the `repo.SearchRepos` handler, which in turn calls
`commitstatus_service.FindReposLastestCommitStatuses()` with an empty
repo list.
That, in turn, will call `git_model.FindBranchesByRepoAndBranchName()`,
with an empty map. With no map, `FindBranchesByRepoAndBranchName()` ends
up querying the entire `branch` table, because no conditions were set
up.
Armed with a gazillion repo & commit shas, we return to
`FindReposLastestCommitStatuses`, and promptly call
`git_model.GetLatestCommitStatusForPairs`, which constructs a monstrous
query with so many placeholders that the database tells us to go
somewhere else, and flips us off. At least on instances the size of
Codeberg. On smaller instances, it will eventually return, and throw
away all the data, and return an empty set, having performed all this
for naught.
We fix this by short-circuiting `FindBranchesByRepoAndBranchName`, and
returning fast if our inputs are empty.
A test case is included.
Fixes #3521 .
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-05-01 00:34:39 +02:00
0ko
abcb23a838
Merge pull request 'Cumulative English locale improvements' ( #3266 ) from 0ko/forgejo:i18n-20240416 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3266
Reviewed-by: Otto <otto@codeberg.org>
2024-04-30 14:49:48 +00:00
Earl Warren
f7b53ef959
Merge pull request 'Fix user mention processing' ( #3565 ) from algernon/forgejo:call-me-maybe into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3565
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-30 12:24:07 +00:00
Earl Warren
9a3a3feb4c
Merge pull request 'Add inline attachments to comments and prevent double handling of mails' ( #3504 ) from Beowulf/forgejo:mail-inline-attachments-not-added-to-comment into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3504
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-30 12:19:42 +00:00
Gergely Nagy
9a01062ae2
Fix user mention processing
...
When mentioning a user, the markup post-processor did not handle the
case where the mentioned user did not exist well: it tried to skip to
the next node, which in turn, ended up skipping the rest of the line.
To fix this, lets skip just the mentioned, but non-existing user, and
continue processing the current node from there.
Fixes #3535 .
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-04-30 12:51:30 +02:00
Beowulf
34134df3a7
added release notes
2024-04-30 12:05:22 +02:00
oliverpool
6ba60f61cb
Merge pull request 'fix: webhook: send short ref on gitea create/delete payload' ( #3558 ) from oliverpool/forgejo:webhook_gitea_fix into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3558
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-30 09:10:39 +00:00
Beowulf
aeb544aff7
added test for reading inline attachments
2024-04-30 10:47:48 +02:00
oliverpool
0d3a9e6491
webhook: send short ref on gitea create/delete payload
2024-04-30 10:41:42 +02:00
oliverpool
cb0f361171
test: webhook gitea tag creation ref
2024-04-30 10:41:38 +02:00
Earl Warren
afb3bcaa8b
Merge pull request 'fix: webhook getPayloadBranch' ( #3555 ) from oliverpool/forgejo:webhook_ref_compat into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3555
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-30 08:15:42 +00:00
oliverpool
df06904f4a
webhook: fix getPayloadBranch
2024-04-30 09:38:35 +02:00
oliverpool
79380c209d
test: webhook fix branch filter tests
2024-04-30 09:38:35 +02:00
Earl Warren
425d64a023
Merge pull request 'Update module connectrpc.com/connect to v1.16.1' ( #3491 ) from renovate/connectrpc.com-connect-1.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3491
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-30 07:10:13 +00:00
Earl Warren
e58a4c9a76
Merge pull request 'Update dependency @stylistic/stylelint-plugin to v2.1.2' ( #3544 ) from renovate/stylistic-stylelint-plugin-2.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3544
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-04-30 07:04:10 +00:00
Earl Warren
79ffb2de47
Merge pull request '[gitea] week 2024-18 cherry pick (gitea-github/main -> forgejo)' ( #3513 ) from earl-warren/wcp/2024-18 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3513
Reviewed-by: jean-daricade <jean-daricade@noreply.codeberg.org>
2024-04-30 06:42:26 +00:00
Earl Warren
fb5c6d3837
Merge pull request 'remove MAINTAINERS
file' ( #3549 ) from Cyborus/forgejo:remove-maintainers into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3549
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-30 05:53:47 +00:00
Earl Warren
fd67dccc5c
Merge pull request 'Fix colour contrast issues in forms' ( #3543 ) from fnetx/form-colour-contrast into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3543
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-30 05:36:14 +00:00
Earl Warren
fdfef07d15
Merge pull request 'Choose better icon for Add more repo units suggestion' ( #3542 ) from fnetx/repo-units-icon into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3542
Reviewed-by: Gergely Nagy <algernon@noreply.codeberg.org>
2024-04-30 05:34:58 +00:00
Earl Warren
a1dbecf3b8
Merge pull request 'Fix toggling WIP state in PR footer' ( #3537 ) from fnetx/fix-wip-toggle-footer into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3537
Reviewed-by: Gergely Nagy <algernon@noreply.codeberg.org>
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
2024-04-30 05:24:31 +00:00
Earl Warren
b4383065d3
Merge pull request 'UI: Disable internal wiki options when enabling external wiki' ( #3533 ) from n0toose/settings/wiki-unit-toggles into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3533
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-30 05:13:46 +00:00
Cyborus
57956d0525
remove MAINTAINERS
file
2024-04-30 00:40:39 -04:00
0ko
11a7d8adfb
[I18N] Cumulative English locale improvements
...
- decap wiki UI
- decap release UI
- fix cap of self visibility toggle button on org member list
- simplify `release.add_tag`
- simplify `admin_indexer_commit_sha` (we got multiple hash types now, but this referes to commit)
- some improvements to admin dashboard
- fnetX suggestions: [[1]](https://codeberg.org/forgejo/forgejo/pulls/3266#issuecomment-1795685 ), [[2]](https://codeberg.org/forgejo/forgejo/pulls/3266#issuecomment-1795734 )
2024-04-30 08:59:46 +05:00
Renovate Bot
a7fcc3ca3f
Update dependency dayjs to v1.11.11
2024-04-30 00:11:43 +00:00
Renovate Bot
aba5fe36d8
Update dependency @stylistic/stylelint-plugin to v2.1.2
2024-04-30 00:11:35 +00:00