More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
```
❯ grep lint-spell Makefile
@echo " - lint-spell lint spelling"
@echo " - lint-spell-fix lint spelling and fix issues"
lint: lint-frontend lint-backend lint-spell
lint-fix: lint-frontend-fix lint-backend-fix lint-spell-fix
.PHONY: lint-spell
lint-spell: lint-codespell
.PHONY: lint-spell-fix
lint-spell-fix: lint-codespell-fix
❯ git grep lint- -- .forgejo/
.forgejo/workflows/testing.yml: - run: make --always-make -j$(nproc) lint-backend checks-backend # ensure the "go-licenses" make target runs
.forgejo/workflows/testing.yml: - run: make lint-frontend
```
so how would you like me to invoke `lint-codespell` on CI? (without that would be IMHO very suboptimal and let typos sneak in)
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3270
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Co-committed-by: Yaroslav Halchenko <debian@onerussian.com>
I thought there would be conflicts but that they would not be so difficult to manage. Worst idea I had this week. Change to @oliverpool idea instead.
> Instead of documenting the release notes in the issue, why not in the codebase?
>
> For instance in [go](https://cs.opensource.google/go/go/+/master:doc/README.md) there is a `doc/next` folder where you add `<pr-number>.md` files which document each pr.
>
> Before the release, a script takes all those files to generate the changelog.
>
> Having them as a file tracked by git, makes them easy to review and to programmatically handle.
Refs: https://codeberg.org/forgejo/discussions/issues/155#issuecomment-1787013
Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3452
Reviewed-by: Gergely Nagy <algernon@noreply.codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
When in the repository settings, visiting
- `LFS` to `/{owner}/{repo}/settings/lfs`
- `Find pointer files` to `/{owner}/{repo}/settings/lfs/pointers`
- `Find commits` to `/{owner}/{repo}/settings/lfs/find?oid=...`
failed with an error 500 because of an incorrect evaluation of the
template.
Regression introduced by
cbf923e87b
A test is added to visit the page and guard against future
regressions.
Refs: https://codeberg.org/forgejo/forgejo/issues/3438
The tests in Forgejo extensively rely on admin user create to create
the first admin user. This regression was not noticed because it
is an exception and a password change will not be required.
Refs: https://codeberg.org/forgejo/forgejo/issues/3399
These release notes need a lot of attention to be good. But they are passable and ready for review.
Multiple factors made them challenging to collect:
- lack of organization Forgejo side which is going to be better for the next version
- complete reorganization of the development workflows which made it challenging to sort out what is in the release or not
- unification of the branches into a single one after the hard fork decision
Refs: https://codeberg.org/forgejo/forgejo/issues/2425
Co-authored-by: 0ko <0ko@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3203
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
(cherry picked from commit b07123ee7b)
(cherry picked from commit ca85c880b4)
(cherry picked from commit 723ead94cb)
(cherry picked from commit ff148318da)
[DOCS] RELEASE-NOTES: 1.19.0
(cherry picked from commit e84e43887b)
[DOCS] RELEASE-NOTES: add scoped access tokens
(cherry picked from commit 688f831853)
[DOCS] RELEASE-NOTES: Scoped labels
(cherry picked from commit 747479a07b)
[DOCS] RELEASE-NOTES: OIDC groups
(cherry picked from commit 10c505fe89)
[DOCS] RELEASE-NOTES: Copy Link is broken
On firefox it fails with Uncaught TypeError: navigator.clipboard is
undefined
On chromium it fails with Uncaught TypeError: Cannot read properties of undefined (reading 'writeText')
(cherry picked from commit 148b2ff093)
[DOCS] RELEASE-NOTES: Copy citation
(cherry picked from commit d0f217735f)
[DOCS] RELEASE-NOTES: Support org/user level projects
(cherry picked from commit de845c7bcf)
[DOCS] RELEASE-NOTES: v1.19 has a documentation
(cherry picked from commit 9a5b46da32)
[DOCS] RELEASE-NOTES: do not split webhook section
(cherry picked from commit 00ed020321)
[DOCS] RELEASE-NOTES: Incoming emails
(cherry picked from commit 06c455b33b)
[DOCS] RELEASE-NOTES: secrets are an implementation detail
(cherry picked from commit 8236dc3a57)
[DOCS] RELEASE-NOTES: Prohibit fork if user reached maximum
(cherry picked from commit 0f80b8c696)
[DOCS] RELEASE-NOTES: scoped tokens: do not duplicate the docs
(cherry picked from commit 9bc4793c07)
[DOCS] RELEASE-NOTES: rss feed for tags and releases
(cherry picked from commit 599b36fada)
[DOCS] RELEASE-NOTES: protected branches wildcard
(cherry picked from commit 2b316c4950)
[DOCS] RELEASE-NOTES: disable releases
(cherry picked from commit 9a60773f1d)
[DOCS] RELEASE-NOTES: review box
(cherry picked from commit 09867dd122)
[DOCS] RELEASE-NOTES: asciicast support
(cherry picked from commit ea9658379b)
[DOCS] RELEASE-NOTES: attention blocks
(cherry picked from commit 70b387750b)
[DOCS] RELEASE-NOTES: commit cross reference
(cherry picked from commit fe706dad13)
[DOCS] RELEASE-NOTES: strip user completion border case
(cherry picked from commit 33ca51b4b6)
[DOCS] RELEASE-NOTES: card preview
(cherry picked from commit 626cd78ca6)
[DOCS] RELEASE-NOTES: raw copy button
(cherry picked from commit edfb467d64)
[DOCS] RELEASE-NOTES: allow edits by maintainers by default
(cherry picked from commit 7006405bc6)
[DOCS] RELEASE-NOTES: database auto migration is a little arcane
(cherry picked from commit 78030fa9af)
[DOCS] RELEASE-NOTES: fix typos & minor rewording
(cherry picked from commit ae1d47f656)
(cherry picked from commit ad08ca9955)
[DOCS] RELEASE-NOTES: webhook authorization header
(cherry picked from commit c35e2c4f6f)
[DOCS] RELEASE-NOTES: video element in markdown
(cherry picked from commit bcb0bd51d2)
[DOCS] RELEASE-NOTES: move scoped labels to the documentation
(cherry picked from commit c5eedaf4f3)
[DOCS] RELEASE-NOTES: cosmetic improvements
(cherry picked from commit b93df350d9)
[DOCS] RELEASE-NOTES: 1.19.0-0 is really : 1.19.0-2
(cherry picked from commit 60d770c2c9)
[DOCS] RELEASE-NOTES: relevant repositories
(cherry picked from commit de6ed5b87f)
(cherry picked from commit 71d91fdf22)
[DOCS] RELEASE-NOTES: semantic version
(cherry picked from commit af062d77f0)
[DOCS] RELEASE-NOTES: reflogs
(cherry picked from commit 084713d8aa)
(cherry picked from commit 90ad322a56)
[DOCS] RELEASE-NOTES: fix broken link to OIDC mapping
(cherry picked from commit 802a252eb5)
[DOCS] RELEASE-NOTES: Fix spaces
(cherry picked from commit a605d36ab6)
[DOCS] RELEASE-NOTES: SemVer
(cherry picked from commit 7b29c90035)
(cherry picked from commit 82799195c9)
(cherry picked from commit 5d9c2e9ec6)
[DOCS] RELEASE-NOTES: 1.19.0-3
(cherry picked from commit c599b2947d)
(cherry picked from commit 8a37027ae7)
[DOCS] RELEASE-NOTES: v1.19.1-0
(cherry picked from commit 89b9e96cc7)
(cherry picked from commit 2b4e881a4e)
[DOCS] RELEASE-NOTES: 1.19.2-0
(cherry picked from commit 0c0d2ec46c)
(cherry picked from commit 437b8caae4)
[DOCS] RELEASE-NOTES: 1.19.3-0
(cherry picked from commit 040740917e)
[DOCS] RELEASE-NOTES: 1.19.3-0 (fix typo)
(cherry picked from commit 24516cb22a)
(cherry picked from commit 429c8e6525)
(cherry picked from commit 8247bddb45)
(cherry picked from commit d77d7b7be7)
(cherry picked from commit a64c899b1d)
(cherry picked from commit 0803eaa2e3)
(cherry picked from commit 8538f2897e)
(cherry picked from commit 45b9037d3c)
(cherry picked from commit 928705f870)
(cherry picked from commit 19e683468c)
(cherry picked from commit 5ae55e8e34)
(cherry picked from commit 7c224d84cf)
[DOCS] RELEASE-NOTES: 1.20.0
(cherry picked from commit 3fbcdd235b)
(cherry picked from commit e7a621acae)
(cherry picked from commit 70adac6d66)
[DOCS] RELEASE-NOTES: 1.20.0-0-rc0 (squash) rewording
(cherry picked from commit 1b79fab57d)
[DOCS] RELEASE-NOTES: 1.20.0-0-rc0 (squash) time
(cherry picked from commit cfd599a132)
[DOCS] RELEASE-NOTES: 1.20.0-0-rc0 (squash) wiki
(cherry picked from commit 6aa2ab41c6)
pick changes from #829
(cherry picked from commit f599598101)
[DOCS] RELEASE-NOTES: 1.20.0-0-rc0 (squash) ui
(cherry picked from commit 5f0aa769b1)
features
(cherry picked from commit d1e788ff4e)
typos
(cherry picked from commit 088d4b2d61)
Mirror Settings
(cherry picked from commit 161412affd)
features
(cherry picked from commit 10cb0379e2)
fix typo
(cherry picked from commit aee096b040)
TODO
(cherry picked from commit 0d4e0bb4a9)
typo
(cherry picked from commit b76a3c1a84)
(cherry picked from commit 4c354196c2)
(cherry picked from commit 6323c6d1a2)
[DOCS] RELEASE-NOTES: 1.20.0 (squash) Woodpecker CI archive repository
(cherry picked from commit 154ee5bc9c)
[DOCS] RELEASE-NOTES: 1.20.0 (squash)
(cherry picked from commit 656f955448)
[DOCS] RELEASE-NOTES: 1.19.4-0
(cherry picked from commit 85bd997176)
[DOCS] RELEASE-NOTES: 1.19.4-0 (squash) fix typo
(cherry picked from commit e5c364c586)
(cherry picked from commit c123048e51)
(cherry picked from commit ad2fedb693)
[DOCS] RELEASE-NOTES: 1.20.0 (squash) blog
Pick changes from https://blog.gitea.com/release-of-1.20.0/
(cherry picked from commit c8068a9d7b)
[DOCS] RELEASE-NOTES: 1.20.0 (squash) Gitea release notes
Review https://github.com/go-gitea/gitea/releases/tag/v1.20.0
(cherry picked from commit dd58b50403)
[DOCS] RELEASE-NOTES: 1.20.0 (squash) commits
git log --no-merges --oneline 64ed262e1..gitea/release/v1.20 . ':(exclude,glob)docs/**' ':(exclude)CONTRIBUTING.md' ':(exclude)MAINTAINERS' ':(exclude,glob).github/**' ':(exclude)CHANGELOG.md' ':(exclude,glob)options/locale/**' ':(exclude,glob)options/license/**' ':(exclude,glob)snap/**' ':(exclude).drone.yml' ':(exclude)custom/conf/app.example.ini'
9159964ad Avoid opening/closing PRs which are already merged (#25883) (#25903)
9369b3831 Skip unuseful error message in dev mode when watching local filesystem (#25919) (#25927)
6e82d0bb7 Add shutting down notice (#25920) (#25922)
36b9a86bd Fix incorrect milestone count when provide a keyword (#25880) (#25904)
de8127e78 fix incorrect repo url when changed the case of ownername (#25733) (#25881)
de8127e78 fix incorrect repo url when changed the case of ownername (#25733) (#25881)
186f07bbf Make `add line comment` buttons focusable (#25894) (#25896)
45b1f4dd3 Add support for different Maven POM encoding (#25873) (#25890)
026e745b9 Fix incorrect release count (#25879) (#25887)
c334be828 Fix empty project displayed in issue sidebar (#25802) (#25854)
353dcc5ad Fix the error message when the token is incorrect (#25701) (#25836)
abe9c641c Show correct SSL Mode on "install page" (#25818) (#25838)
052e65e63 Fix incorrect oldest sort in project list (#25806) (#25835)
c1a10be07 Fix activity type match in `matchPullRequestEvent` (#25746) (#25796)
2b79d3fd5 For API attachments, use API URL (#25639) (#25814)
b4460cf54 Make "install page" respect environment config (#25648) (#25799)
a1bc2aa05 Avoid amending the Rebase and Fast-forward merge if there is no message template (#25779) (#25809)
d713cf615 Fix WORK_DIR for docker (root) image (#25738) (#25811)
012b804a9 Clarify "text-align" CSS helpers, fix clone button padding (#25763) (#25764)
372b622c2 Revert package access change from #23879 (#25707) (#25785)
06bcdfe77 Remove unused code (#25734) (#25788)
a5a3c8141 Fix notification list bugs (#25781) (#25787)
ea2c9de3c Test if container blob is accessible before mounting (#22759) (#25784)
348a6bf70 Always pass 6-digit hex color to monaco (#25780) (#25782)
91dadeddd Translate untranslated string in issues list (#25759) (#25761)
32eaba1b4 Hide `add file` button for pull mirrors (#25748) (#25751)
917ca5ded Several fixes for mobile UI (#25634) (#25689)
e595dfeec Allow/fix review (approve/reject) of empty PRs (#25690) (#25732)
03cacf971 Check `ctx.Written()` for `GetActionIssue` (#25698) (#25711)
68e0c802f Show correct naming for 1 comment (#25704) (#25712)
09668b2e2 Correct permissions for `.ssh` and `authorized_keys` (#25721) (#25730)
04eea29ec Fix tags header and pretty format numbers (#25624) (#25694)
511be9fe6 Fix position of org follow button (#25688) (#25692)
24e64fe37 Replace `interface{}` with `any` (#25686) (#25687)
4e310133f Prevent duplicate image loading (#25675) (#25684)
491f36d32 Actions list enhancements (#25601) (#25678)
5510ed34f Fix the nil pointer when assigning issues to projects (#25665) (#25677)
39fce5750 Prevent SVG shrinking (#25652) (#25669)
1f9037604 Fix show more for image on diff page (#25672) (#25673)
0af6542a3 Add unit test for repository collaboration (#25640) (#25658)
69bdcf41f Log the real reason when authentication fails (but don't show the user) (#25414) (#25660)
e610b0389 Fix UI misalignment on user setting page (#25629) (#25656)
13ffa287b Fix bug of branches API with tests(#25578) (#25579)
(cherry picked from commit 3e9e862e5e)
[DOCS] RELEASE-NOTES: 1.20.0 (squash) reorder breaking
(cherry picked from commit 4e4cdddc55)
address rome-user review
(cherry picked from commit 8791fe88b1)
[DOCS] RELEASE-NOTES: 1.20.0 (squash) reword breaking
- removed the section about the changed themes: it is an internal
detail and redundant with the above warning regarding themes &
templates
(cherry picked from commit b34e9a7b19)
[DOCS] RELEASE-NOTES: 1.20.0 (squash) minor rewording
The CI & Actions sections were grouped together.
(cherry picked from commit ed236e1ee8)
[DOCS] RELEASE-NOTES: 1.20.1-0 (squash)
(cherry picked from commit 3c11eb1de5)
[DOCS] RELEASE-NOTES: 1.20.1-0 (squash) Forgejo features/optimizations
(cherry picked from commit c516fd0c7a)
[DOCS] RELEASE-NOTES: 1.20.1-0 (squash) fix typo in Alpine version
(cherry picked from commit 1c2a5b5162)
[DOCS] RELEASE-NOTES: 1.20.1-0 (squash) comment out obsoleted queue keys
(cherry picked from commit 8c0d9459c5)
[DOCS] RELEASE-NOTES: 1.20.1-0 (squash) WORK_PATH breaking change
(cherry picked from commit f4ea3b27f5)
(cherry picked from commit 0557568f61)
[DOCS] RELEASE-NOTES.md (squash) obsolete queue `app.ini` keys
(cherry picked from commit e0c943ac3b)
[DOCS] RELEASE-NOTES.md (squash) v1.20.2-0
(cherry picked from commit f2c654d1c8)
[DOCS] RELEASE-NOTES.md (squash) fix LFS issue link
(cherry picked from commit 2461355f2a)
(cherry picked from commit 750652d75a)
(cherry picked from commit 6899dbdc11)
(cherry picked from commit 88b988d084)
[DOCS] RELEASE-NOTES.md (squash) v1.20.3-0
(cherry picked from commit d566e78d68)
(cherry picked from commit 65439eafa4)
(cherry picked from commit a76cc5b8bc)
(cherry picked from commit b4e1ad6020)
[DOCS] RELEASE-NOTES.md (squash) v1.20.4-0
(cherry picked from commit 8a910c0c33)
[DOCS] RELEASE-NOTES.md (squash) link to upgrade docs
Refs: https://codeberg.org/forgejo/forgejo/issues/1199
(cherry picked from commit d4e9030873)
(cherry picked from commit 7da7b9cef4)
(cherry picked from commit 73b64ea895)
[DOCS] RELEASE-NOTES.md (squash) v1.20.4-1
[DOCS] RELEASE-NOTES.md (squash) v1.21.0-0
(cherry picked from commit e618ea55a5)
(cherry picked from commit f3ee986416)
[DOCS] RELEASE-NOTES.md (squash) 1.20.5-0
(cherry picked from commit ce5541c78b)
[DOCS] RELEASE-NOTES.md (squash) 1.20.5-0 is a security release
(cherry picked from commit 5dd66c06e3)
slug of the blog post changed
(cherry picked from commit fc5b52049f)
apply caesar rewording suggestions
(cherry picked from commit 59e9648b71)
[DOCS] RELEASE-NOTES.md (squash) typo
(cherry picked from commit e8daead2a1)
(cherry picked from commit 8af0a2007d)
(cherry picked from commit 329a04e094)
(cherry picked from commit 216a62de30)
(cherry picked from commit 855440d4b3)
(cherry picked from commit 6cb87ca0fe)
(cherry picked from commit d2bf04bfa3)
[DOCS] RELEASE-NOTES.md (squash) v1.21.0-0
[DOCS] RELEASE-NOTES.md (squash) v1.21.0-0 new features (UI split)
[DOCS] RELEASE-NOTES.md (squash) v1.21.0-0 complete release notes.
(cherry picked from commit cd0fbfc8ed)
RSA keylength 3072 is a breaking change
(cherry picked from commit ac6defb515)
new features chroma update from 2.7.0 to 2.9.1
(cherry picked from commit ffd249070a)
new features go-enry/linguist update from v7.25.0 to v7.27.0
go-enry 2.8.6
(cherry picked from commit 1e72c0608f)
add links to documentation for new features
(cherry picked from commit ab0ff5d2d0)
v1.21.0-9 will be the release number
(cherry picked from commit afed47fa40)
links to go-enry & chroma releases to measure the gap
(cherry picked from commit deb7645550)
[DOCS] RELEASE-NOTES.md (squash) v1.20.5-1
(cherry picked from commit ab1556628d)
proofread
(cherry picked from commit fd672635b2)
[DOCS] RELEASE-NOTES.md (squash) v1.20.6-0
(cherry picked from commit 90ddda3413)
[DOCS] RELEASE-NOTES.md (squash) v1.21.1-0
(cherry picked from commit 079d4fdca1)
[DOCS] RELEASE-NOTES.md (squash) v1.21.1-0
(cherry picked from commit f3d15ef97c)
(cherry picked from commit 881b438f2d)
(cherry picked from commit 6080cf05c9)
[DOCS] RELEASE-NOTES.md (squash) v1.21.2-0
(cherry picked from commit 9f4ca4cdf9)
[DOCS] RELEASE-NOTES.md (squash) v1.21.2-0
(cherry picked from commit 363477855e)
[DOCS] RELEASE-NOTES.md (squash) move customized files
make it more prominently visible
(cherry picked from commit 6c992b5d93)
[DOCS] RELEASE-NOTES.md (squash) API pull/issue breaking change
(cherry picked from commit a8cbc2deb8)
(cherry picked from commit 58657fff86)
(cherry picked from commit ecf8b1531b)
[DOCS] RELEASE-NOTES.md (squash) v1.21.2-1
(cherry picked from commit 1d24c09f49)
[DOCS] RELEASE-NOTES.md (squash) v1.20.6-1
(cherry picked from commit 8821315c33)
[DOCS] RELEASE-NOTES.md (squash) v1.20.6-1 reorder
(cherry picked from commit 9159916fa1)
(cherry picked from commit 165099c0c6)
[DOCS] RELEASE-NOTES.md (squash) v1.21.3-0
(cherry picked from commit 5e1d37b76c)
[DOCS] RELEASE-NOTES.md (squash) v1.21.3-0
Reword the security fix description.
(cherry picked from commit 142bed073d)
(cherry picked from commit cff9b5db4a)
[DOCS] RELEASE-NOTES (squash) mention addition of `auth-required` in Cargo registry
I'm including this under bug fixes even though it was labelled as an
enhancement upstream because stabilization of private registry
authentication predates the introduction of this change. Feel free to
change the category if you don't think this assessment is appropriate.
Refs: https://codeberg.org/forgejo/forgejo/pulls/2038
(cherry picked from commit 1057df6db5)
(cherry picked from commit 566c32bdf6)
(cherry picked from commit 45f5657cdc)
(cherry picked from commit cb222316c2)
(cherry picked from commit b44dae67f3)
(cherry picked from commit f48ef0b788)
