Lunny Xiao
e3ed67859a
Move some functions to service layer ( #26969 )
2023-09-08 21:09:23 +00:00
silverwind
b8ad558c93
Lock yamllint and update indirect python deps ( #26979 )
...
I forgot to lock `yamllint` to exact version, so did that and
regenerated `poetry.lock` as well.
2023-09-08 15:36:40 -04:00
silverwind
4693bdbda0
Chroma color tweaks ( #26978 )
2023-09-08 11:03:01 -05:00
Lunny Xiao
9c0a3532a4
Add a new column schedule_id for action_run to track ( #26975 )
...
Fix #26971
And the UI now will display it's scheduled but not triggered by a push.
<img width="954" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/d211845c-457e-4c3e-af1f-a0d654d3f365 ">
2023-09-08 23:01:19 +08:00
wxiaoguang
ffa4949eaa
Improve flex list UI ( #26970 )
...
1. There is already `gt-ac`, so no need to introduce `flex-item-center`
2. The `flex-item-baseline` and `.flex-item-icon svg { margin-top: 1px
}` seem to be a tricky patch, they don't resolve the root problem, and
still cause misalignment in some cases.
* The root problem is: the "icon" needs to align with the sibling
"title"
* So, make the "icon" and the "title" both have the same height
3. `flex-text-inline` could only be used if the element is really
"inline", otherwise its `vertical-align` would make the box size change.
In most cases, `flex-text-block` is good enough.
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
2023-09-08 13:57:18 +00:00
wxiaoguang
4807f7be22
Clarify the git command Stdin hanging problem ( #26967 )
2023-09-08 13:20:38 +00:00
Lunny Xiao
bafe1334c6
Add v1.20.4 changelog ( #26974 )
...
frontport from #26966
---------
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
2023-09-08 10:32:26 +00:00
wxiaoguang
80d14b8f4a
Check newly added node type before "attachDirAuto" ( #26972 )
2023-09-08 18:17:08 +08:00
zareck
4e240f2304
Expanding documentation in queue.go ( #26889 )
...
A set of terminology, along with a broader description, can help more
people engage with the Gitea queue system, providing insights and
ensuring its correct use.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-09-08 05:22:43 +00:00
Lunny Xiao
4f32abaf94
move repository deletion to service layer ( #26948 )
...
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-09-08 04:51:15 +00:00
silverwind
3c0c279658
Add yamllint ( #26965 )
...
So that https://github.com/go-gitea/gitea/pull/26964 does not happen
again. Merge this after that PR. Config is based on
[node's](https://github.com/nodejs/node/blob/main/.yamllint.yaml ).
---------
Co-authored-by: techknowlogick <techknowlogick@gitea.com>
2023-09-07 22:24:06 -04:00
silverwind
f9abb6ade2
Fix yaml quoting ( #26964 )
...
Yaml [does not
like](https://github.com/go-gitea/gitea/actions/runs/6115139962/job/16598147278?pr=26568 )
keys that start with `*` so let's quote all globs.
2023-09-07 20:50:10 -04:00
GiteaBot
6cbbd51ad4
[skip ci] Updated translations via Crowdin
2023-09-08 00:21:56 +00:00
silverwind
cfa3527118
Add actions/labeler ( #26962 )
...
Implements https://github.com/GiteaBot/gitea-backporter/issues/93 using
[`actions/labeler`](https://github.com/actions/labeler ). Very basic
configuration, can be extended later.
2023-09-07 21:30:03 +00:00
Jack Hay
1a9953348c
Team invite url fix when registration disabled ( #26950 )
...
This is a follow-on to https://github.com/go-gitea/gitea/pull/26550 and
fixes the case where the team invite links to the registration page if
it is disabled in settings.
2023-09-07 14:50:45 +00:00
CaiCandong
30cea70dd8
Refactor dashboard/feed.tmpl ( #26956 )
...
- ~~Refactor `ActionType` to `models/activities/action_type.go`~~
- Replace the magic number in `feed.tmlp` with `InAction`
2023-09-07 16:23:13 +02:00
Lunny Xiao
f20e317d6d
Improve hint when uploading a too large avatar ( #26935 )
...
Fix #26390
---------
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: silverwind <me@silverwind.io>
2023-09-07 13:35:45 +00:00
CaiCandong
a78c2eae24
Replace util.SliceXxx with slices.Xxx ( #26958 )
2023-09-07 09:37:47 +00:00
Lunny Xiao
e97e883ad5
Add reverseproxy auth for API back with default disabled ( #26703 )
...
This feature was removed by #22219 to avoid possible CSRF attack.
This PR takes reverseproxy auth for API back but with default disabled.
To prevent possbile CSRF attack, the responsibility will be the
reverseproxy but not Gitea itself.
For those want to enable this `ENABLE_REVERSE_PROXY_AUTHENTICATION_API`,
they should know what they are doing.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
2023-09-07 08:31:46 +00:00
wxiaoguang
1221221595
Add "dir=auto" for input/textarea elements by default ( #26735 )
...
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
2023-09-07 08:00:20 +00:00
Lunny Xiao
d1dca38a2a
Fix schedule actions still running even if workflow disalbed ( #26939 )
...
Fix #26782
2023-09-07 10:25:46 +08:00
Nanguan Lin
1ee4882b88
Fix the missing repo count ( #26942 )
...
The commit
(958d148043😝
BTW, the `leave` button is in a weird position
2023-09-07 01:44:47 +00:00
wxiaoguang
419003adb2
Improve SSH Key / GPG Key / Deploy Key UI ( #26949 )
...
1. In many cases, the `flex-list` has previous and next `gt-hidden`
siblings, so relax the CSS selector to remove all ".segument .flex-list"
paddings.
2. Make the "Add key" button can toggle
3. Move help message into the related segment(panel). Otherwise users
would misread the message, eg: the SSH help seemed for GPG because they
are so near
4. Move modal element into the segment element, otherwise it affects the
layout
2023-09-07 01:13:11 +00:00
GiteaBot
9860dba566
[skip ci] Updated translations via Crowdin
2023-09-07 00:22:15 +00:00
silverwind
e596806217
Update nginx recommendations ( #26924 )
...
- `Connection` and `Upgrade` [needed for
websockets](https://www.nginx.com/blog/websocket-nginx/ )
- ~~`X-Real-IP` unnecessary and duplicate with `X-Forwarded-For`. [chi
checks both
headers](https://github.com/go-chi/chi/blob/master/middleware/realip.go ),
but XFF is definitely the more "standard" one.~~
2023-09-06 17:49:45 +00:00
Panagiotis "Ivory" Vasilopoulos
d1353ad55a
docs: Update Profile README information ( #26947 )
...
Follow-up of https://github.com/go-gitea/gitea/pull/26295
2023-09-06 10:22:50 -04:00
wxiaoguang
2715ef6558
Fix scoped label layout ( #26932 )
...
Fix #26931
2023-09-06 12:22:38 +00:00
Lunny Xiao
b9df9fa2e2
Move createrepository from module to service layer ( #26927 )
...
Repository creation depends on many models, so moving it to service
layer is better.
2023-09-06 12:08:51 +00:00
KazzmanK
b3d88ada01
Add a documentation note for Windows Service ( #26938 )
...
Service may fail to start at boot time with timeout
Resolves #26934
Co-authored-by: Nikolay Kobzarev <n.kobzarev@aeronavigator.ru>
2023-09-06 11:14:12 +00:00
merlleu
a7d9a70552
allow "latest" to be used in release vTag when downloading file ( #26748 )
...
Hello,
In the discord I saw
[someone](https://discord.com/channels/322538954119184384/1069795723178160168/1145061200644800514 )
complaining that you can't use the "latest" keyword as release tag to
download a specific file:
In his example:
https://www.uberwald.me/gitea/public/fvtt-ecryme/releases/latest/system.json
However the latest keyword works for the release page, so I think it's a
good thing to implement this on the release attachment download url too.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-09-06 11:06:04 +00:00
Kerwin Bryant
9b0743ae33
Extract common code to new template ( #26933 )
...
Same as #26903
2023-09-06 10:11:06 +00:00
JakobDev
7812ce86dc
Show always repo count in header ( #26842 )
...
A few pages don't load the repo count of an user/org, so it is not shown
in the header. This happens mostly on org pages, but the package
settings applies to the user page as well.
Before:
After:
Seen on #26826
Regression of #25928
2023-09-06 09:34:26 +00:00
JakobDev
958d148043
Show always repo count in header ( #26842 )
...
A few pages don't load the repo count of an user/org, so it is not shown
in the header. This happens mostly on org pages, but the package
settings applies to the user page as well.
Before:
After:
Seen on #26826
Regression of #25928
2023-09-06 08:49:36 +00:00
FuXiaoHei
460a2b0edf
Artifacts retention and auto clean up ( #26131 )
...
Currently, Artifact does not have an expiration and automatic cleanup
mechanism, and this feature needs to be added. It contains the following
key points:
- [x] add global artifact retention days option in config file. Default
value is 90 days.
- [x] add cron task to clean up expired artifacts. It should run once a
day.
- [x] support custom retention period from `retention-days: 5` in
`upload-artifact@v3`.
- [x] artifacts link in actions view should be non-clickable text when
expired.
2023-09-06 07:41:06 +00:00
Kerwin Bryant
113eb5fc24
Fix UI anomalies ( #26929 )
2023-09-06 07:00:45 +00:00
yp05327
0850be6750
Fix the display of org level badges ( #26504 )
...
Follow #24654 #22705 #24232
In some pages we still have missing badges, for example:
2023-09-06 14:38:14 +08:00
Lunny Xiao
31c92d9695
Add missing translation ( #26926 )
...
Fix #26923
2023-09-05 22:13:08 -04:00
silverwind
97aa749578
Vendor jquery.are-you-sure with strict mode fixes ( #26901 )
...
Extract from https://github.com/go-gitea/gitea/pull/25940 and because
https://github.com/go-gitea/gitea/pull/26743 does seem to need more
work.
This will be required if we are to run our JS in [strict
mode](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode ).
Previously, the two variables `$fields` and `$dirtyForms` polluted
`window`:
<img width="1145" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/e0270a0e-b881-4ed7-9cc4-e9ab25c0a2bc ">
2023-09-06 00:02:44 +00:00
Nanguan Lin
01e71e2a47
Fix the secret regexp pattern on web page ( #26910 )
...
The error is caused by the web page not handling the post form
failure, which is 400 bad requests in this case.
2023-09-05 20:15:19 +00:00
Rui Chen
bfa22a473e
Add @chenrui333 as maintainer ( #26917 )
...
relates to https://gitea.com/gitea/homebrew-gitea/pulls/179
Signed-off-by: Rui Chen <rui@chenrui.dev>
2023-09-05 14:47:07 -04:00
Lunny Xiao
540bf9fa6d
Move notification interface to services layer ( #26915 )
...
Extract from #22266
2023-09-05 18:37:47 +00:00
techknowlogick
084eacb5d4
fetch emails of currently displayed user on admin page ( #26918 )
...
Currently, this fetches the emails from the user viewing the page. This
PR changes it to show the emails from the user whose page it is.
2023-09-05 17:56:21 +00:00
Sven Seeberg
5f7fa27a44
Improve LDAP group config documentation, fixes #21159 ( #21227 )
...
Improve the wording of the LDAP group attributes documentation and
expand the examples.
2023-09-05 13:18:53 -04:00
techknowlogick
e67ddaa0f8
update footer link to new landing page ( #26916 )
...
as title
Co-authored-by: Giteabot <teabot@gitea.io>
2023-09-05 16:44:07 +00:00
KN4CK3R
0eebeeec90
Remove Named interface ( #26913 )
...
`Named` is implemented by every `Method` and future implementations
should implement the method too.
2023-09-05 15:58:30 +00:00
KN4CK3R
a99b96cbcd
Refactor secrets modification logic ( #26873 )
...
- Share code between web and api
- Add some tests
2023-09-05 15:21:02 +00:00
JakobDev
e9f5067653
Add missing reqToken() to notifications endpoints ( #26914 )
...
They currently throw a Internal Server Error when you use them without a
token. Now they correctly return a `token is required` error.
This is no security issue. If you use this endpoints with a token that
don't have the correct permission, you get the correct error. This is
not affected by this PR.
2023-09-05 14:43:34 +00:00
Bo-Yi Wu
f79f6a26ae
feat(API): add routes and functions for managing user's secrets ( #26909 )
...
- Add routes for creating or updating a user's actions secrets in
`routers/api/v1/api.go`
- Add a new file `routers/api/v1/user/action.go` with functions for
creating or updating a user's secrets and deleting a user's secret
- Modify the `templates/swagger/v1_json.tmpl` file to include the routes
for creating or updating a user's secrets and deleting a user's secret
---------
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2023-09-05 14:02:50 +00:00
Lunny Xiao
f064d716c3
Move feed notification service layer ( #26908 )
...
Extract from #22266
2023-09-05 13:00:52 +00:00
Kerwin Bryant
65588b732c
Extract common code to new template ( #26903 )
...
I noticed that the code of several new webhook pages is highly
repetitive, so I pulled out the common parts to a new template, unified
reference, unified maintenance
---------
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2023-09-05 12:00:28 +00:00
