Commit graph

4064 commits

Author SHA1 Message Date
erik 0378b2dc7d Add questions for review discussion 2024-02-10 15:16:36 +01:00
Michael Jerger 1704ac5bc2 fix most of the tests 2024-02-10 15:14:35 +01:00
Michael Jerger e1d7db178c unify logging & minor improvements 2024-02-10 15:14:31 +01:00
Michael Jerger 3172eb69d2 introduce RepositoryId 2024-02-10 15:14:08 +01:00
Michael Jerger 1fe35e14a5 mv our actor code to forgefed 2024-02-10 15:14:07 +01:00
Michael Jerger abdf56dde1 move forgefed to models 2024-02-10 15:14:06 +01:00
Michael Jerger 184388015d added more tests 2024-02-10 15:10:39 +01:00
Michael Jerger b5a467e94d remove unused & implement webfinger 2024-02-10 15:10:38 +01:00
Michael Jerger e8371ca94c ActorId -> PersonId 2024-02-10 15:10:37 +01:00
Michael Jerger 3151c8fe81 make validate more compact 2024-02-10 15:10:37 +01:00
Michael Jerger be4d3544ae Refactor ActorID -> ActorId 2024-02-10 15:10:36 +01:00
Michael Jerger afcc7f0def factory instead of parse & validate 2024-02-10 15:10:35 +01:00
erik 3c515c2614 Add review todos 2024-02-10 15:10:33 +01:00
erik 6ad52a6d67 Update tests 2024-02-10 15:10:24 +01:00
erik 25d34e0c14 Check for empty path in IRI 2024-02-10 15:10:22 +01:00
erik fa1acd1ebb Extract url string validation and parsing from ActorID parsing 2024-02-10 15:10:19 +01:00
erik 4d3ab4dda2 Update Validate() 2024-02-10 15:10:19 +01:00
erik 39d4c8dd2d Generalize validate_is_not_empty 2024-02-10 15:10:17 +01:00
erik 085db0c127 Remove todo 2024-02-10 15:10:16 +01:00
Michael Jerger 28a290da10 reviewed current work 2024-02-10 15:10:13 +01:00
erik 02dc8901af Fix tests 2024-02-10 15:10:13 +01:00
erik 68cd621053 Test for empty string 2024-02-10 15:10:12 +01:00
erik 946e5cf34c Remove typo in func 2024-02-10 15:10:10 +01:00
erik c0f1681fa3 Allow parsing of repository-id too 2024-02-10 15:10:09 +01:00
erik 4f25e5057a Make the source an argument to the parser 2024-02-10 15:10:08 +01:00
erik 52e950a492 Check the path for empty strings 2024-02-10 15:10:06 +01:00
erik 65f7124c67 Use u.Hostname() instead of u.Host
u.Host returns hostname:port.
2024-02-10 15:10:05 +01:00
erik 27c9db1027 Better function descriptions 2024-02-10 15:10:05 +01:00
Michael Jerger 9b5d8bbeda If we use user.loginname to store the actor.id we can search for local users earlier 2024-02-10 15:10:04 +01:00
erik fde8de4f90 Rename to ParseActorIDFromStarActivity 2024-02-10 15:09:35 +01:00
erik ede86df685 Remove todo 2024-02-10 15:09:34 +01:00
erik 8a53331283 Add ToDo 2024-02-10 15:09:30 +01:00
erik 9568eab62a Fix tests 2024-02-10 15:09:29 +01:00
erik 566b3bc459 Parse Actor from star activity, Update function declaration order 2024-02-10 15:09:28 +01:00
erik 3a938b6c3f Use and validate source in ActorID struct 2024-02-10 15:09:28 +01:00
erik 9566e9bc5d Change tests to use IsValid method 2024-02-10 15:09:27 +01:00
erik fccf5c37ca Add IsValid and PanicIfInvalid methods for ActorID 2024-02-10 15:09:26 +01:00
erik 8300d3fbde Add ToDos from code review 2024-02-10 15:09:25 +01:00
erik 91baf2be32 Add get functions for userId and HostAndPort 2024-02-10 15:09:23 +01:00
erik 92c089a4e2 Add a test for getting host and port 2024-02-10 15:09:23 +01:00
erik 8657f70960 Add todo 2024-02-10 15:09:21 +01:00
erik 5efce01f6f Make test messages consistent 2024-02-10 15:09:21 +01:00
erik ad8adc880f Create easier to read tests for parser and validator 2024-02-10 15:09:20 +01:00
erik 62eae6564f Fix bug in validation 2024-02-10 15:09:20 +01:00
erik d205c50a43 Implement generic validation on ActorID 2024-02-10 15:09:19 +01:00
erik 7b5d13a625 Split check for schema and host 2024-02-10 15:09:19 +01:00
erik 3d2b5115ad Implement and use Validatable interface 2024-02-10 15:09:18 +01:00
erik 235ed7cd1e Rename to actorID 2024-02-10 15:09:18 +01:00
Michael Jerger fbff67f11a add some more todos 2024-02-10 15:09:09 +01:00
erik 5729cee3e5 Move test to model/activitypub 2024-02-10 15:09:07 +01:00