Emmanuel BENOÎT
0801518f5d
fix(actions): prevent deleted records' UUID from colliding with new records ( #3830 )
...
This commit changes the code that deletes a runner so it updates the UUID before deleting the record. The new UUID is set to 8 0xff bytes followed by a little endian version of the record's numeric ID. Such UUIDs cannot be created from tokens when registering runners, as the first 16 bytes of the token are in the `[0-9a-f]` range. This should prevent deleted runners from colliding with new records if the tokens share the same first 16 characters.
It is a possible solution to issue #3828
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3830
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Emmanuel BENOÎT <tseeker@nocternity.net>
Co-committed-by: Emmanuel BENOÎT <tseeker@nocternity.net>
2024-05-19 10:46:15 +00:00
Earl Warren
23bbec4459
tests(services/mailer): refactor mail_admin_new_user_test
...
* use MockVariableValue where appropriate
* split the tests in two with t.Run for clarity
2024-05-19 08:54:25 +02:00
David Davies-Payne
e4c3c039be
Suppress Monaco JavaScript errors in Safari ( #3805 )
...
Fix #3638
This is a manual Forgejo-specific version of the Gitea PR https://github.com/go-gitea/gitea/pull/30862 . The weekly Forgejo PR #3772 could not cherry-pick this commit due to conflicts (eg subsequent CodeSpell changes).
Only occurs with Webkit in Safari over eg `http://192 ..`. (not localhost).
See https://webkit.org/blog/10855/async-clipboard-api/
---
**Before**
**After**
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3805
Reviewed-by: Otto <otto@codeberg.org>
Co-authored-by: David Davies-Payne <d2p@me.com>
Co-committed-by: David Davies-Payne <d2p@me.com>
2024-05-18 21:07:09 +00:00
Earl Warren
11a031e238
Merge pull request '[I18N] Some English decap and other fixes' ( #3823 ) from 0ko/forgejo:i18n-20240518 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3823
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-18 06:52:53 +00:00
Earl Warren
ed46d44b97
Merge pull request 'Fix overflowing titles in project columns' ( #3821 ) from beowulf/projects-issue-title-overflows into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3821
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-18 06:44:48 +00:00
0ko
1b12ca80ec
[I18N] Some English decap and other fixes
2024-05-18 10:24:39 +05:00
Beowulf
853f005180
fixed overflow of projects column title
...
This fixes that titles of project columns can overflow and push the
action menu out of the card, so that interaction is no longer possible.
Fixes #3717
2024-05-17 23:11:11 +02:00
Earl Warren
deec6c43a1
Merge pull request 'Fix contrast for issue count in projects columns' ( #3804 ) from beowulf/projects-column-issue-count-contrast into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3804
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-17 10:14:08 +00:00
0ko
f9ac5b327a
Remove title from email heads ( #3810 )
...
One part of https://codeberg.org/forgejo/forgejo/pulls/3316 , though it may have a little more files touched because I re-created the changes.
> Removed HTML `<title>` part in `<head>` that was present inconsistently in these emails. It doesn't appear to be used by other websites. After all, these are emails, not webpages.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3810
Reviewed-by: Otto <otto@codeberg.org>
2024-05-17 10:10:33 +00:00
Michael Jerger
5ce359b14e
rename fkt name
2024-05-17 08:15:51 +02:00
Michael Jerger
8b90194d1b
lint it
2024-05-17 07:54:46 +02:00
Renovate Bot
f64c2e0a7f
Update dependency @github/text-expander-element to v2.7.0
2024-05-17 00:06:12 +00:00
Beowulf
82e0066ed4
Fixed contrast for issue count in projects column
...
Regression introduced by 9934931f1f#3772
2024-05-17 00:54:10 +02:00
Michael Jerger
b2c3eb1644
add migration & enhance int-test
2024-05-16 18:25:16 +02:00
Earl Warren
45a41811de
Merge pull request 'Update dependency mermaid to v10.9.1' ( #3776 ) from renovate/mermaid-10.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3776
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-16 15:55:54 +00:00
Earl Warren
e47dd122f8
chore(release-notes): update dependency mermaid to v10.9.1
...
Refs: https://codeberg.org/forgejo/forgejo/pulls/3776
2024-05-16 15:34:17 +02:00
Earl Warren
e8c32255da
Merge pull request 'Port: Fix some UI problems (install) (gitea#30854)' ( #3787 ) from Mai-Lapyst/forgejo:cherry-pick-30854 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3787
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-16 13:13:48 +00:00
Earl Warren
d30fa97729
Merge pull request 'Update module github.com/go-swagger/go-swagger/cmd/swagger to v0.31.0' ( #3778 ) from renovate/github.com-go-swagger-go-swagger-cmd-swagger-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3778
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-16 13:10:44 +00:00
Earl Warren
56ca2e43e9
Merge pull request 'test: add more sha256 repositories tests' ( #3794 ) from oliverpool/forgejo:push_deploy_sha256 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3794
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-16 13:02:44 +00:00
Otto
c4d7045a24
Merge pull request 'template: label fix correct input id' ( #3789 ) from Frankkkkk/forgejo:fvd/fix-label into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3789
Reviewed-by: Beowulf <beowulf@noreply.codeberg.org>
Reviewed-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
2024-05-16 10:15:10 +00:00
oliverpool
67effd6985
test-sha256: APICreateFile
2024-05-16 11:01:47 +02:00
oliverpool
df8aaeb1d5
test-sha256: APICreateBranch
2024-05-16 10:54:40 +02:00
oliverpool
348182f4b3
test-sha256: PushDeployKeyOnEmptyRepo
2024-05-16 10:54:40 +02:00
oliverpool
e3e82d02ad
test: useless duplication
2024-05-16 09:56:13 +02:00
Michael Jerger
1c7a9b00be
initial
2024-05-16 08:15:43 +02:00
0ko
fc0c5e80da
Fix and improve repo visibility checkbox when FORCE_PRIVATE is on ( #3786 )
...
This was [implemented](022820103dhttps://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly ), `readonly` attribute is not applicable to checkbox inputs. This bug was reported by mrwusel in Matrix room.
Fork page that has similar UI feature did not have this bug.
- replace `readonly` with `disabled`
- do not put info about the restriction directly into the checkbox title
### Before
### After
### In other case
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3786
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-16 05:51:55 +00:00
Frank Villaro-Dixon
208eed05ff
template: label fix correct input id
...
Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>
2024-05-15 23:13:05 +02:00
Earl Warren
cb551effb9
Merge pull request 'fix: hook post-receive for sha256 repos' ( #3652 ) from oliverpool/forgejo:hook_post_receive_error into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3652
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-15 21:06:24 +00:00
wxiaoguang
c16ae1ab39
Fix some UI problems (install) ( #30854 )
...
(cherry picked from commit ce8b11ae131bef6cd7df0849ed39da7984953a4b)
2024-05-15 20:12:14 +02:00
oliverpool
5e73c67d67
fix: hook post-receive for sha256 repos
2024-05-15 16:43:16 +02:00
oliverpool
2ac3dcbd43
test: hook post-receive for sha256 repos
...
failing push-to-create for sha256 will be fixed in a followup PR
2024-05-15 16:27:00 +02:00
Earl Warren
fe3473fc8b
Merge pull request 'Update dependency happy-dom to v14.11.0' ( #3777 ) from renovate/happy-dom-14.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3777
2024-05-15 06:31:30 +00:00
Renovate Bot
a2dc3cb388
Update module github.com/jhillyerd/enmime to v1.2.0
2024-05-15 02:07:19 +00:00
Renovate Bot
ca5186978e
Update module github.com/go-swagger/go-swagger/cmd/swagger to v0.31.0
2024-05-15 02:05:32 +00:00
Renovate Bot
103ad53f45
Update dependency happy-dom to v14.11.0
2024-05-15 00:06:10 +00:00
Renovate Bot
03e2aed969
Update dependency mermaid to v10.9.1
2024-05-15 00:05:40 +00:00
Earl Warren
77092c7a0c
Merge pull request 'Federation: Parse ActorId & cache FederationHost' ( #3662 ) from meissa/forgejo:forgejo-federated-parse-actorId into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3662
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-14 22:42:02 +00:00
Earl Warren
48813e6be1
Merge pull request 'Port "Enable declaration-block-no-redundant-longhand-properties ( #30950 )' ( #3769 ) from beowulf/gitea-port-pull-30950 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3769
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-14 22:23:54 +00:00
Shiny Nematoda
b6ca8abcfd
[FEAT] support searching non default branches/tags when using git-grep ( #3654 )
...
resolves https://codeberg.org/forgejo/forgejo/pulls/3639#issuecomment-1806676 and https://codeberg.org/forgejo/forgejo/pulls/3513#issuecomment-1794990
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3654
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
2024-05-14 15:41:03 +00:00
silverwind
8f4e653020
Enable declaration-block-no-redundant-longhand-properties ( #30950 )
...
Enable
[`declaration-block-no-redundant-longhand-properties`](https://stylelint.io/user-guide/rules/declaration-block-no-redundant-longhand-properties/ )
and autofix issues. The exclusions are because I find these two
shorthands to be harder to read.
(cherry picked from commit 46b7004f050bd2fdaf9800794cf2c1e9eeb08d51)
Signed-off-by: Beowulf <beowulf@beocode.eu>
2024-05-14 17:28:58 +02:00
Earl Warren
9b4452fd7b
Merge pull request '[DOC] fix release notes link' ( #3768 ) from snematoda/fix-release-notes-link into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3768
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-14 14:56:12 +00:00
Shiny Nematoda
fd1fff11cc
[skip ci] fix release notes link
2024-05-14 12:48:07 +00:00
Earl Warren
1b3e6a4831
Merge pull request '[gitea] week 2024-20 cherry pick (gitea-github/main -> forgejo)' ( #3729 ) from earl-warren/wcp/2024-20 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3729
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-05-14 12:23:10 +00:00
Earl Warren
a6262a662e
Merge pull request 'Expand code diffs against the commits repo' ( #3765 ) from algernon/forgejo:<del>300</del>500 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3765
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-14 12:04:04 +00:00
Earl Warren
b88bae5c5a
Merge pull request 'Enable renovate osv vulnerability alerts' ( #2788 ) from viceice/forgejo:chore/renovate into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2788
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-05-14 12:01:47 +00:00
Earl Warren
069b78b305
Merge pull request 'Fixes indentation style in .editorconfig for go.mod' ( #3754 ) from beowulf/fix-editorconfig-for-go.mod into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3754
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-05-14 11:39:15 +00:00
Earl Warren
6c1573d0aa
Merge pull request 'Update dependency postcss-nesting to v12.1.4' ( #3756 ) from renovate/postcss-packages into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3756
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-05-14 11:37:55 +00:00
Earl Warren
b60a302821
Merge pull request 'Update dependency swagger-ui-dist to v5.17.9' ( #3757 ) from renovate/swagger-ui-dist-5.17.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3757
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-05-14 11:36:59 +00:00
Earl Warren
3c490163ea
Merge pull request 'Update module connectrpc.com/connect to v1.16.2' ( #3758 ) from renovate/connectrpc.com-connect-1.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3758
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-05-14 11:35:32 +00:00
Earl Warren
2ed61cbe35
Merge pull request 'Update dependency happy-dom to v14.10.2' ( #3755 ) from renovate/happy-dom-14.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3755
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-05-14 11:33:37 +00:00
