Gusted
0692cc2cc1
[BUG] First user created through reverse proxy should be admin
...
- Currently users created through the reverse proxy aren't created
trough the normal route of `createAndHandleCreatedUser` as this does a
lot of other routines which aren't necessary for the reverse proxy auth,
however one routine is important to have: the first created user should
be an admin. This patch adds that code
- Adds unit test.
- Resolves #4437
2024-08-19 21:04:35 +02:00
Otto
3b8ac4388a
Merge pull request 'Refactor grouped forms to semantic HTML' ( #4995 ) from fnetx/refactor-grouped-forms into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4995
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-08-19 14:53:35 +00:00
Earl Warren
0c70e11df8
Merge pull request 'git-grep: refactor defaults' ( #4964 ) from yoctozepto/git-grep-refactor-defaults into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4964
Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>
2024-08-19 13:12:37 +00:00
Radosław Piliszek
f784260633
git-grep: refactor defaults
...
One method to set them all... or something like that.
The defaults for git-grep options were scattered over the run
function body. This change refactors them into a separate method.
The application of defaults is checked implicitly by existing
tests and linters, and the new approach makes it very easy
to inspect the desired defaults are set.
2024-08-19 14:28:01 +02:00
Earl Warren
7e37c4d831
Merge pull request '[BUG] Don't fire notification for comment of pending review' ( #4487 ) from gusted/webhook-issue into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4487
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-19 09:04:50 +00:00
Earl Warren
74f08b5da0
Merge pull request 'feat: add forgejo-cli to the container images' ( #5012 ) from earl-warren/forgejo:wip-cli into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5012
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-08-19 08:47:57 +00:00
limiting-factor
b6efebc237
feat: add forgejo-cli to the container images
...
When the Forgejo CLI binary is `forgejo-cli`, the `--verbose` or `--quiet`
arguments are available globally for all sub-commands. The same
sub-commands can be used with `forgejo forgejo-cli`, those flags are
not available.
2024-08-19 09:44:04 +02:00
Earl Warren
c7adff3862
Merge pull request 'Lock file maintenance (forgejo)' ( #5011 ) from renovate/forgejo-lock-file-maintenance into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5011
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-08-19 07:42:40 +00:00
Earl Warren
51620ab0f3
Merge pull request 'Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v1.60.1 (forgejo)' ( #4953 ) from renovate/forgejo-github.com-golangci-golangci-lint-cmd-golangci-lint-1.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4953
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-19 07:38:14 +00:00
forgejo-renovate-action
15e131fd67
Merge pull request 'Update renovate to v38.39.6 (forgejo)' ( #5007 ) from renovate/forgejo-renovate into forgejo
2024-08-19 06:04:05 +00:00
Renovate Bot
e650b25bb6
Lock file maintenance
2024-08-19 02:05:17 +00:00
Renovate Bot
1b9222f6e2
Update renovate to v38.39.6
2024-08-19 02:03:33 +00:00
Gusted
f3bd849bef
Merge pull request 'Update dependency @stylistic/stylelint-plugin to v3.0.1 (forgejo)' ( #5008 ) from renovate/forgejo-stylistic-stylelint-plugin-3.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5008
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-19 01:18:20 +00:00
Renovate Bot
6012bcb2b9
Update dependency @stylistic/stylelint-plugin to v3.0.1
2024-08-19 00:09:17 +00:00
Otto Richter
c9e402afdc
feat(tmpl): Introduce semantic HTML in forms
...
Modifies forms:
- (new) org team
- (new) repo webhook
- (new) repo protected branch
The forms are not completely rewritten to semantic HTML yet. The focus
of this change was on standard elements, some custom solutions were left
untouched for now.
- swaps the order fo permission radio buttons as per https://codeberg.org/forgejo/forgejo/issues/4983
- uses fieldsets to group related inputs
- ensures consistent styling across forms
- can be improved later, e.g. using horizontal lines between sections
- fixes: previous font size of labels was smaller than the font size of the help text
- help text are now part of the label, clicking them now also activates the input
- drop unused CSS (no required checkboxes in grouped class remain)
- playwright testing:
- move login boilerplate to utils
- automated form accessibility checking
- allow defining the scope, because legacy parts of the forms are not yet accessible
- assert some CSS properties that should not be overriden
- the Makefile adjustment was necessary, because eslint scanned some internal files in the tests/e2e/reports directory
2024-08-19 01:14:18 +02:00
Otto
f9ba752140
Merge pull request '[UI] Fix misalignment of authors for repo acctivity' ( #5003 ) from gusted/forgejo-fix-chartjs into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5003
Reviewed-by: Otto <otto@codeberg.org>
2024-08-18 20:11:50 +00:00
Earl Warren
90e03e410a
Merge pull request 'feat: upgrade F3 to v3.7.0' ( #5004 ) from earl-warren/forgejo:wip-f3 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5004
Reviewed-by: Otto <otto@codeberg.org>
2024-08-18 19:30:15 +00:00
Gusted
72f41306c2
[UI] Fix misalignment of authors for repo acctivity
...
- Regression of #4571
- We aren't showing the ticks generated by chartjs, because we want to
show the avatar of the person instead. You can't *realy* disable that
tick, so instead I opted to make them transparent in #4571 , however they
still affected the generation of ticks so if enough authors were being
shown, for some the ticks were being skipped. Adjust the settings to
make sure they are always being shown.
- Resolves https://codeberg.org/forgejo/forgejo/issues/4982
2024-08-18 21:18:29 +02:00
limiting-factor
b26a0aea19
feat: upgrade F3 to v3.7.0
...
* support changing label colors
* support changing issue state
* use helpers to keep type conversions DRY
* drop the x/exp license because it is no longer used
The tests are performed by the gof3 compliance suite
2024-08-18 19:39:20 +02:00
Otto
2cbc9cec73
Merge pull request 'Enable switch check in linter' ( #4555 ) from thefox/reenable-switch-check into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4555
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
2024-08-18 15:56:35 +00:00
Gusted
22d57cfc6b
Merge pull request 'chore(make): structure and clean up Makefile a little' ( #4979 ) from fnetx/makefile-structure into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4979
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-18 15:27:02 +00:00
Gusted
15c64122a6
[BUG] Don't fire notification for comment of pending review
...
- When a comment was updated or deleted and was part of an
pending/ongoing review, it would have triggered a notification, such as
a webhook.
- This patch checks if the comment is part of a pending review and then
does not fire a notification and, in the case of updating a comment,
does not save the content history because this is not necessary if it is
still a "draft" comment given it is a pending comment (there is no need
to see my embarrassing typos).
- Adds integration tests.
- Resolves https://codeberg.org/forgejo/forgejo/issues/4368
2024-08-18 17:04:00 +02:00
TheFox0x7
f7bb75ce56
revert: accidental change
2024-08-18 16:36:06 +02:00
Gusted
fe18428806
Fix linting issues
2024-08-18 16:25:13 +02:00
TheFox0x7
529bbbde4d
style: change one argument switch to if
2024-08-18 16:20:26 +02:00
Renovate Bot
674689af4a
Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v1.60.1
2024-08-18 16:03:29 +02:00
TheFox0x7
0813126058
test: add more workflow event coverage
2024-08-18 15:19:01 +02:00
TheFox0x7
8322882265
style: reenable switch check
2024-08-18 15:19:01 +02:00
Otto Richter
7e0cebecb0
Drop docker target from Makefile
...
as per https://codeberg.org/forgejo/forgejo/pulls/4979#issuecomment-2181764
2024-08-18 15:14:34 +02:00
Earl Warren
adf4dcdbbf
Merge pull request 'Update docker.io/bitnami/minio Docker tag to v2024.8.17 (forgejo)' ( #4994 ) from renovate/forgejo-docker.io-bitnami-minio-2024.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4994
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-18 05:24:26 +00:00
Earl Warren
5ae1c96893
chore(renovate): bitnami/minio is now docker.io/bitnami/minio
2024-08-18 06:37:45 +02:00
Renovate Bot
2960f78adb
Update docker.io/bitnami/minio Docker tag to v2024.8.17
2024-08-18 00:02:17 +00:00
Otto
4760c5029d
Merge pull request 'i18n: Improve clarity of confirmation email messages' ( #4980 ) from fnetx/activation-code-clarity into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4980
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-17 15:31:48 +00:00
Otto
2f501e9d74
Merge pull request 'fix: add gap between branch dropdown and PR button' ( #4971 ) from n0toose/gap-part-two into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4971
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Caesar Schinas <caesar@caesarschinas.com>
2024-08-17 12:11:05 +00:00
Earl Warren
9b66710bf5
Merge pull request 'Update docker.io/bitnami/mysql Docker tag to v8.4 (forgejo)' ( #4961 ) from renovate/forgejo-docker.io-bitnami-mysql-8.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4961
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-17 07:46:57 +00:00
Earl Warren
fbb2252314
Merge pull request 'git-grep: fix for initial dashes in expressions' ( #4967 ) from yoctozepto/git-grep-fix-words into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4967
Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>
2024-08-17 07:07:40 +00:00
Earl Warren
e2dee395e4
Merge pull request 'Update docker.io/bitnami/minio Docker tag to v2024.8.3 (forgejo)' ( #4960 ) from renovate/forgejo-docker.io-bitnami-minio-2024.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4960
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-17 06:58:28 +00:00
Earl Warren
022d7c16ca
Merge pull request 'Update module mvdan.cc/gofumpt to v0.7.0 (forgejo)' ( #4988 ) from renovate/forgejo-mvdan.cc-gofumpt-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4988
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-17 05:18:56 +00:00
Earl Warren
3524bfaf0c
Merge pull request 'Update dependency @playwright/test to v1.46.1 (forgejo)' ( #4987 ) from renovate/forgejo-playwright-monorepo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4987
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-17 05:18:35 +00:00
Gusted
760b99bd5a
Merge pull request 'test: fail on unhandled JS exceptions' ( #4959 ) from solomonv/e2e-fail-on-errors into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4959
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Caesar Schinas <caesar@caesarschinas.com>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-17 00:58:18 +00:00
Renovate Bot
1b8a79f820
Update module mvdan.cc/gofumpt to v0.7.0
2024-08-17 00:02:59 +00:00
Renovate Bot
c078e14472
Update dependency @playwright/test to v1.46.1
2024-08-17 00:02:44 +00:00
Otto
da7f3ac6f5
Merge pull request '[BUG] Make logout event non-blocking' ( #4938 ) from gusted/forgejo-non-blocking-logout into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4938
Reviewed-by: Otto <otto@codeberg.org>
2024-08-16 14:17:15 +00:00
Otto Richter
2e9f4cece4
i18n: Improve clarity of confirmation email messages
...
Fixes https://codeberg.org/forgejo/forgejo/issues/4399
2024-08-16 16:11:18 +02:00
Otto Richter
b390641478
Drop vendor filter (dir is gone), left-align help messages
2024-08-16 15:28:48 +02:00
Otto Richter
ac5d4f68d1
Comments for structure, moving things around, drop Gitea mentions
2024-08-16 15:04:25 +02:00
Otto Richter
f2ab8c8ea7
Drop legacy update-translation target
2024-08-16 14:54:55 +02:00
Earl Warren
24eb401a0a
Merge pull request 'Enhancing Gitea OAuth2 Provider with Granular Scopes for Resource Access' ( #4449 ) from marcellmars/forgejo:forgejo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4449
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-16 12:38:15 +00:00
Earl Warren
8e91cf1b26
Merge pull request 'Add .mailmap with aliases for Unknwon (github.com/Unknwon)' ( #4956 ) from yarikoptic/forgejo:enh-mailmap into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4956
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-08-16 09:04:41 +00:00
Earl Warren
c7fe944357
Merge pull request 'Update dependency @stylistic/eslint-plugin-js to v2.6.4 (forgejo)' ( #4972 ) from renovate/forgejo-eslint-stylistic-monorepo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4972
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-08-16 08:58:42 +00:00