fedi/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-29 15:57:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix counter display number incorrectly displayed on the page (#29448)

Browse source 
issue : #28239

The counter number script uses the 'checkbox' attribute to determine
whether an item is selected or not.

However, the input event only increments the counter value, and when
more items are displayed, it does not update all previously loaded
items.

As a result, the display becomes incorrect because it triggers the
update counter script, but checkboxes that are selected without the
'checked' attribute are not counted

(cherry picked from commit 252047ed2e09e3f1f1ab394cd62995cf4cabe506)
This commit is contained in:
charles 2024-02-29 04:23:49 +08:00 committed by Earl Warren
parent 9c5afa0b8f
commit afc21e6aa7
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
web_src/js/features/pull-view-file.js
View file

@ -43,9 +43,11 @@ export function initViewedCheckboxListenerFor() {
// Mark the file as viewed visually - will especially change the background // Mark the file as viewed visually - will especially change the background
if (this.checked) { if (this.checked) {
form.classList.add(viewedStyleClass); form.classList.add(viewedStyleClass);
checkbox.setAttribute('checked', '');
prReview.numberOfViewedFiles++; prReview.numberOfViewedFiles++;
} else { } else {
form.classList.remove(viewedStyleClass); form.classList.remove(viewedStyleClass);
checkbox.removeAttribute('checked');
prReview.numberOfViewedFiles--; prReview.numberOfViewedFiles--;
} }