From 7d74b8596c9a763221fb9ff91e06c0af3f02c958 Mon Sep 17 00:00:00 2001 From: Manush Dodunekov Date: Thu, 9 Jan 2020 01:37:39 +0100 Subject: [PATCH] Avoid extra loop --- models/access.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/models/access.go b/models/access.go index 64153d1070..15214b82b9 100644 --- a/models/access.go +++ b/models/access.go @@ -191,21 +191,16 @@ func (repo *Repository) refreshAccesses(e Engine, accessMap map[int64]*userAcces minMode = AccessModeWrite } - // build a map of the actual entries we want to create - entryMap := make(map[int64]AccessMode, len(accessMap)) + newAccesses := make([]Access, 0, len(accessMap)) for userID, ua := range accessMap { if ua.Mode < minMode && !ua.User.IsRestricted { continue } - entryMap[userID] = ua.Mode - } - - newAccesses := make([]Access, 0, len(entryMap)) - for userID, mode := range entryMap { + newAccesses = append(newAccesses, Access{ UserID: userID, RepoID: repo.ID, - Mode: mode, + Mode: ua.Mode, }) }