fedi/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-20 15:42:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Uncapitalize errors (#18915)

Browse source 
- See: https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
Gusted 2022-02-26 12:15:32 +00:00 committed by GitHub
parent fa0e2d60c2
commit 6d55a132a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
routers/web/repo/issue.go
View file

@ -2557,7 +2557,7 @@ func updateAttachments(item interface{}, files []string) error {
case *models.Comment: case *models.Comment:
attachments = content.Attachments attachments = content.Attachments
default: default:
return fmt.Errorf("Unknown Type: %T", content) return fmt.Errorf("unknown Type: %T", content)
} }
for i := 0; i < len(attachments); i++ { for i := 0; i < len(attachments); i++ {
if util.IsStringInSlice(attachments[i].UUID, files) { if util.IsStringInSlice(attachments[i].UUID, files) {
@ -2575,7 +2575,7 @@ func updateAttachments(item interface{}, files []string) error {
case *models.Comment: case *models.Comment:
err = content.UpdateAttachments(files) err = content.UpdateAttachments(files)
default: default:
return fmt.Errorf("Unknown Type: %T", content) return fmt.Errorf("unknown Type: %T", content)
} }
if err != nil { if err != nil {
return err return err
@ -2587,7 +2587,7 @@ func updateAttachments(item interface{}, files []string) error {
case *models.Comment: case *models.Comment:
content.Attachments, err = repo_model.GetAttachmentsByCommentID(content.ID) content.Attachments, err = repo_model.GetAttachmentsByCommentID(content.ID)
default: default:
return fmt.Errorf("Unknown Type: %T", content) return fmt.Errorf("unknown Type: %T", content)
} }
return err return err
} }

10
routers/web/repo/lfs.go
View file

@ -120,14 +120,14 @@ func LFSLocks(ctx *context.Context) {
Shared: true, Shared: true,
}); err != nil { }); err != nil {
log.Error("Failed to clone repository: %s (%v)", ctx.Repo.Repository.FullName(), err) log.Error("Failed to clone repository: %s (%v)", ctx.Repo.Repository.FullName(), err)
ctx.ServerError("LFSLocks", fmt.Errorf("Failed to clone repository: %s (%v)", ctx.Repo.Repository.FullName(), err)) ctx.ServerError("LFSLocks", fmt.Errorf("failed to clone repository: %s (%v)", ctx.Repo.Repository.FullName(), err))
return return
} }
gitRepo, err := git.OpenRepositoryCtx(ctx, tmpBasePath) gitRepo, err := git.OpenRepositoryCtx(ctx, tmpBasePath)
if err != nil { if err != nil {
log.Error("Unable to open temporary repository: %s (%v)", tmpBasePath, err) log.Error("Unable to open temporary repository: %s (%v)", tmpBasePath, err)
ctx.ServerError("LFSLocks", fmt.Errorf("Failed to open new temporary repository in: %s %v", tmpBasePath, err)) ctx.ServerError("LFSLocks", fmt.Errorf("failed to open new temporary repository in: %s %v", tmpBasePath, err))
return return
} }
defer gitRepo.Close() defer gitRepo.Close()
@ -140,7 +140,7 @@ func LFSLocks(ctx *context.Context) {
if err := gitRepo.ReadTreeToIndex(ctx.Repo.Repository.DefaultBranch); err != nil { if err := gitRepo.ReadTreeToIndex(ctx.Repo.Repository.DefaultBranch); err != nil {
log.Error("Unable to read the default branch to the index: %s (%v)", ctx.Repo.Repository.DefaultBranch, err) log.Error("Unable to read the default branch to the index: %s (%v)", ctx.Repo.Repository.DefaultBranch, err)
ctx.ServerError("LFSLocks", fmt.Errorf("Unable to read the default branch to the index: %s (%v)", ctx.Repo.Repository.DefaultBranch, err)) ctx.ServerError("LFSLocks", fmt.Errorf("unable to read the default branch to the index: %s (%v)", ctx.Repo.Repository.DefaultBranch, err))
return return
} }
@ -525,14 +525,14 @@ func LFSAutoAssociate(ctx *context.Context) {
for i, oid := range oids { for i, oid := range oids {
idx := strings.IndexRune(oid, ' ') idx := strings.IndexRune(oid, ' ')
if idx < 0 || idx+1 > len(oid) { if idx < 0 || idx+1 > len(oid) {
ctx.ServerError("LFSAutoAssociate", fmt.Errorf("Illegal oid input: %s", oid)) ctx.ServerError("LFSAutoAssociate", fmt.Errorf("illegal oid input: %s", oid))
return return
} }
var err error var err error
metas[i] = &models.LFSMetaObject{} metas[i] = &models.LFSMetaObject{}
metas[i].Size, err = strconv.ParseInt(oid[idx+1:], 10, 64) metas[i].Size, err = strconv.ParseInt(oid[idx+1:], 10, 64)
if err != nil { if err != nil {
ctx.ServerError("LFSAutoAssociate", fmt.Errorf("Illegal oid input: %s %v", oid, err)) ctx.ServerError("LFSAutoAssociate", fmt.Errorf("illegal oid input: %s %v", oid, err))
return return
} }
metas[i].Oid = oid[:idx] metas[i].Oid = oid[:idx]

2
routers/web/repo/webhook.go
View file

@ -106,7 +106,7 @@ func getOrgRepoCtx(ctx *context.Context) (*orgRepoCtx, error) {
}, nil }, nil
} }
return nil, errors.New("Unable to set OrgRepo context") return nil, errors.New("unable to set OrgRepo context")
} }
func checkHookType(ctx *context.Context) string { func checkHookType(ctx *context.Context) string {