fedi/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 16:47:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enhance stylelint rule config, remove dead CSS (#24472)

Browse source 
Make this stylelint rule match on more properties.

The dead CSS relates to the navbar, which currently has classes:

```
ui top secondary stackable main menu following bar light
```

Which means `.following.bar .top.menu` can never match, so remove this
dead CSS as well as inactive `z-index` and `left` on it.

Commits table striping becomes more visible on dark theme, but I don't
think it's worth introducing a new color until
https://github.com/go-gitea/gitea/pull/24423 is ready, which would have
to remove it again:

<img width="668" alt="Screenshot 2023-05-01 at 18 41 49"
src="https://user-images.githubusercontent.com/115237/235489873-6b272899-1d78-443a-872c-ee7731c269f9.png">
<img width="680" alt="Screenshot 2023-05-01 at 18 41 41"
src="https://user-images.githubusercontent.com/115237/235489878-1b9468af-c74f-48a6-a469-9eba57cfcb4d.png">
This commit is contained in:
silverwind 2023-05-03 05:15:52 +02:00 committed by GitHub
parent 3362620ee3
commit 3ae997614a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.stylelintrc.yaml
View file

@ -96,7 +96,7 @@ rules:
property-no-vendor-prefix: null property-no-vendor-prefix: null
rule-empty-line-before: null rule-empty-line-before: null
rule-selector-property-disallowed-list: null rule-selector-property-disallowed-list: null
scale-unlimited/declaration-strict-value: [color, {ignoreValues: /^(inherit|transparent|unset|initial|currentcolor)$/}] scale-unlimited/declaration-strict-value: [[color, background-color, border-color], {ignoreValues: /^(inherit|transparent|unset|initial|currentcolor|none)$/, ignoreFunctions: false}]
selector-attribute-name-disallowed-list: null selector-attribute-name-disallowed-list: null
selector-attribute-operator-allowed-list: null selector-attribute-operator-allowed-list: null
selector-attribute-operator-disallowed-list: null selector-attribute-operator-disallowed-list: null

20
web_src/css/base.css
View file

@ -1228,8 +1228,6 @@ img.ui.avatar,
} }
.following.bar { .following.bar {
z-index: 900;
left: 0;
margin: 0 !important; margin: 0 !important;
} }
@ -1242,24 +1240,6 @@ img.ui.avatar,
margin-top: 0; margin-top: 0;
} }
.following.bar .top.menu a.item.brand {
padding-left: 0;
}
.following.bar .top.menu a.item:hover,
.following.bar .top.menu .dropdown.item:hover,
.following.bar .top.menu .dropdown.item.active {
background-color: transparent;
}
.following.bar .top.menu a.item:hover {
color: rgba(0, 0, 0, 0.45);
}
.following.bar .top.menu .menu {
z-index: 900;
}
.following.bar .fitted .svg { .following.bar .fitted .svg {
margin-right: 0; margin-right: 0;
vertical-align: middle; vertical-align: middle;

2
web_src/css/repository.css
View file

@ -1359,7 +1359,7 @@
} }
.repository #commits-table.ui.basic.striped.table tbody tr:nth-child(2n) { .repository #commits-table.ui.basic.striped.table tbody tr:nth-child(2n) {
background-color: rgba(0, 0, 0, 0.02) !important; background-color: var(--color-light) !important;
} }
.repository #commits-table td.sha .sha.label, .repository #commits-table td.sha .sha.label,