mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-22 16:47:30 +00:00
ui: fix wrong string used in a search box (#4258)
Resolves https://codeberg.org/forgejo/forgejo/issues/4256. Fixes regression caused by https://github.com/go-gitea/gitea/pull/29530/files#diff-b46ae540c8eb41d1ccaa1659489fcc47d72eee4c4f04dc83c5ccf4d6d1a3395eR45. Preview: Before - https://codeberg.org/forgejo/forgejo/attachments/d629f2e9-0d07-4719-9250-52d3ba9f4a9e After - https://codeberg.org/forgejo/forgejo/attachments/6a5f5cb2-124d-4673-a387-8483125a89eb Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4258 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Otto <otto@codeberg.org>
This commit is contained in:
parent
616291485e
commit
28ceec6fad
1
release-notes/8.0.0/fix/4258.md
Normal file
1
release-notes/8.0.0/fix/4258.md
Normal file
|
@ -0,0 +1 @@
|
|||
Fix wrong placeholder text in the form for adding repository collaborator
|
|
@ -42,7 +42,7 @@
|
|||
<form class="ui form" id="repo-collab-form" action="{{.Link}}" method="post">
|
||||
{{.CsrfTokenHtml}}
|
||||
<div id="search-user-box" class="ui search input tw-align-middle">
|
||||
<input class="prompt" name="collaborator" placeholder="{{ctx.Locale.Tr "search.team_kind"}}" autocomplete="off" autofocus required>
|
||||
<input class="prompt" name="collaborator" placeholder="{{ctx.Locale.Tr "search.user_kind"}}" autocomplete="off" autofocus required>
|
||||
</div>
|
||||
<button class="ui primary button">{{ctx.Locale.Tr "repo.settings.add_collaborator"}}</button>
|
||||
</form>
|
||||
|
|
37
tests/integration/repo_collaborator_test.go
Normal file
37
tests/integration/repo_collaborator_test.go
Normal file
|
@ -0,0 +1,37 @@
|
|||
// Copyright 2024 The Forgejo Authors. All rights reserved.
|
||||
// SPDX-License-Identifier: MIT
|
||||
|
||||
package integration
|
||||
|
||||
import (
|
||||
"net/http"
|
||||
"net/url"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
// TestRepoCollaborators is a test for contents of Collaborators tab in the repo settings
|
||||
// It only covers a few elements and can be extended as needed
|
||||
func TestRepoCollaborators(t *testing.T) {
|
||||
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
||||
session := loginUser(t, "user2")
|
||||
|
||||
// Visit Collaborators tab of repo settings
|
||||
response := session.MakeRequest(t, NewRequest(t, "GET", "/user2/repo1/settings/collaboration"), http.StatusOK)
|
||||
page := NewHTMLParser(t, response.Body).Find(".repo-setting-content")
|
||||
|
||||
// Veirfy header
|
||||
assert.EqualValues(t, "Collaborators", strings.TrimSpace(page.Find("h4").Text()))
|
||||
|
||||
// Veirfy button text
|
||||
page = page.Find("#repo-collab-form")
|
||||
assert.EqualValues(t, "Add collaborator", strings.TrimSpace(page.Find("button.primary").Text()))
|
||||
|
||||
// Veirfy placeholder
|
||||
placeholder, exists := page.Find("#search-user-box input").Attr("placeholder")
|
||||
assert.True(t, exists)
|
||||
assert.EqualValues(t, "Search users...", placeholder)
|
||||
})
|
||||
}
|
Loading…
Reference in a new issue