fedi/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 17:14:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve branches list performance and fix protected branch icon when no-login (#7695)

Browse source
This commit is contained in:
Lunny Xiao 2019-08-01 22:50:06 +08:00 committed by techknowlogick
parent a4b7a4f2f8
commit 02999c9a44
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
routers/repo/branch.go
View file

@ -162,6 +162,12 @@ func loadBranches(ctx *context.Context) []*Branch {
return nil return nil
} }
protectedBranches, err := ctx.Repo.Repository.GetProtectedBranches()
if err != nil {
ctx.ServerError("GetProtectedBranches", err)
return nil
}
branches := make([]*Branch, len(rawBranches)) branches := make([]*Branch, len(rawBranches))
for i := range rawBranches { for i := range rawBranches {
commit, err := rawBranches[i].GetCommit() commit, err := rawBranches[i].GetCommit()
@ -170,11 +176,13 @@ func loadBranches(ctx *context.Context) []*Branch {
return nil return nil
} }
var isProtected bool
branchName := rawBranches[i].Name branchName := rawBranches[i].Name
isProtected, err := ctx.Repo.Repository.IsProtectedBranch(branchName, ctx.User) for _, b := range protectedBranches {
if err != nil { if b.BranchName == branchName {
ctx.ServerError("IsProtectedBranch", err) isProtected = true
return nil break
}
} }
divergence, divergenceError := repofiles.CountDivergingCommits(ctx.Repo.Repository, branchName) divergence, divergenceError := repofiles.CountDivergingCommits(ctx.Repo.Repository, branchName)