2017-04-29 05:52:25 +00:00
|
|
|
// Copyright 2017 The Gitea Authors. All rights reserved.
|
2022-11-27 18:20:29 +00:00
|
|
|
// SPDX-License-Identifier: MIT
|
2017-04-29 05:52:25 +00:00
|
|
|
|
2022-09-02 19:18:23 +00:00
|
|
|
package integration
|
2017-04-29 05:52:25 +00:00
|
|
|
|
|
|
|
import (
|
2019-09-20 05:45:38 +00:00
|
|
|
"fmt"
|
2017-04-29 05:52:25 +00:00
|
|
|
"net/http"
|
2022-04-07 18:59:56 +00:00
|
|
|
"net/url"
|
2017-06-18 13:25:58 +00:00
|
|
|
"path"
|
2017-06-15 03:09:03 +00:00
|
|
|
"strconv"
|
|
|
|
"strings"
|
2017-04-29 05:52:25 +00:00
|
|
|
"testing"
|
2020-01-07 11:23:09 +00:00
|
|
|
"time"
|
2017-04-29 05:52:25 +00:00
|
|
|
|
2022-06-13 09:37:59 +00:00
|
|
|
"code.gitea.io/gitea/models/db"
|
|
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
2021-12-10 01:27:50 +00:00
|
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
2021-11-16 08:53:21 +00:00
|
|
|
"code.gitea.io/gitea/models/unittest"
|
2021-11-24 09:49:20 +00:00
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
2020-01-07 11:23:09 +00:00
|
|
|
"code.gitea.io/gitea/modules/indexer/issues"
|
2019-10-13 22:29:10 +00:00
|
|
|
"code.gitea.io/gitea/modules/references"
|
2017-06-15 03:09:03 +00:00
|
|
|
"code.gitea.io/gitea/modules/setting"
|
2022-04-07 18:59:56 +00:00
|
|
|
api "code.gitea.io/gitea/modules/structs"
|
2017-12-15 21:11:02 +00:00
|
|
|
"code.gitea.io/gitea/modules/test"
|
2022-09-02 19:18:23 +00:00
|
|
|
"code.gitea.io/gitea/tests"
|
2017-06-15 03:09:03 +00:00
|
|
|
|
|
|
|
"github.com/PuerkitoBio/goquery"
|
2017-04-29 05:52:25 +00:00
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
)
|
|
|
|
|
2017-09-16 20:16:21 +00:00
|
|
|
func getIssuesSelection(t testing.TB, htmlDoc *HTMLDoc) *goquery.Selection {
|
|
|
|
issueList := htmlDoc.doc.Find(".issue.list")
|
|
|
|
assert.EqualValues(t, 1, issueList.Length())
|
|
|
|
return issueList.Find("li").Find(".title")
|
2017-06-15 03:09:03 +00:00
|
|
|
}
|
|
|
|
|
2022-06-13 09:37:59 +00:00
|
|
|
func getIssue(t *testing.T, repoID int64, issueSelection *goquery.Selection) *issues_model.Issue {
|
2017-06-15 03:09:03 +00:00
|
|
|
href, exists := issueSelection.Attr("href")
|
|
|
|
assert.True(t, exists)
|
|
|
|
indexStr := href[strings.LastIndexByte(href, '/')+1:]
|
|
|
|
index, err := strconv.Atoi(indexStr)
|
|
|
|
assert.NoError(t, err, "Invalid issue href: %s", href)
|
2022-08-16 02:22:25 +00:00
|
|
|
return unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{RepoID: repoID, Index: int64(index)})
|
2017-06-15 03:09:03 +00:00
|
|
|
}
|
|
|
|
|
2022-06-13 09:37:59 +00:00
|
|
|
func assertMatch(t testing.TB, issue *issues_model.Issue, keyword string) {
|
2017-09-16 20:16:21 +00:00
|
|
|
matches := strings.Contains(strings.ToLower(issue.Title), keyword) ||
|
|
|
|
strings.Contains(strings.ToLower(issue.Content), keyword)
|
|
|
|
for _, comment := range issue.Comments {
|
|
|
|
matches = matches || strings.Contains(
|
|
|
|
strings.ToLower(comment.Content),
|
|
|
|
keyword,
|
|
|
|
)
|
|
|
|
}
|
|
|
|
assert.True(t, matches)
|
|
|
|
}
|
|
|
|
|
2017-05-27 03:34:11 +00:00
|
|
|
func TestNoLoginViewIssues(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2017-05-27 03:34:11 +00:00
|
|
|
|
2017-06-10 00:41:36 +00:00
|
|
|
req := NewRequest(t, "GET", "/user2/repo1/issues")
|
2017-07-07 19:36:47 +00:00
|
|
|
MakeRequest(t, req, http.StatusOK)
|
2017-05-27 03:34:11 +00:00
|
|
|
}
|
|
|
|
|
2017-09-16 20:16:21 +00:00
|
|
|
func TestViewIssuesSortByType(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2017-06-15 03:09:03 +00:00
|
|
|
|
2022-08-16 02:22:25 +00:00
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
2017-06-15 03:09:03 +00:00
|
|
|
|
2017-06-17 04:49:45 +00:00
|
|
|
session := loginUser(t, user.Name)
|
2021-11-16 18:18:25 +00:00
|
|
|
req := NewRequest(t, "GET", repo.Link()+"/issues?type=created_by")
|
2017-07-07 19:36:47 +00:00
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
2017-06-15 03:09:03 +00:00
|
|
|
|
2017-06-17 16:29:59 +00:00
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
2017-09-16 20:16:21 +00:00
|
|
|
issuesSelection := getIssuesSelection(t, htmlDoc)
|
2021-11-16 08:53:21 +00:00
|
|
|
expectedNumIssues := unittest.GetCount(t,
|
2022-06-13 09:37:59 +00:00
|
|
|
&issues_model.Issue{RepoID: repo.ID, PosterID: user.ID},
|
2021-11-16 08:53:21 +00:00
|
|
|
unittest.Cond("is_closed=?", false),
|
|
|
|
unittest.Cond("is_pull=?", false),
|
2017-06-15 03:09:03 +00:00
|
|
|
)
|
|
|
|
if expectedNumIssues > setting.UI.IssuePagingNum {
|
|
|
|
expectedNumIssues = setting.UI.IssuePagingNum
|
|
|
|
}
|
|
|
|
assert.EqualValues(t, expectedNumIssues, issuesSelection.Length())
|
|
|
|
|
|
|
|
issuesSelection.Each(func(_ int, selection *goquery.Selection) {
|
|
|
|
issue := getIssue(t, repo.ID, selection)
|
|
|
|
assert.EqualValues(t, user.ID, issue.PosterID)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2017-09-16 20:16:21 +00:00
|
|
|
func TestViewIssuesKeyword(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2017-09-16 20:16:21 +00:00
|
|
|
|
2022-08-16 02:22:25 +00:00
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
2022-06-13 09:37:59 +00:00
|
|
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{
|
2020-01-07 11:23:09 +00:00
|
|
|
RepoID: repo.ID,
|
|
|
|
Index: 1,
|
2022-08-16 02:22:25 +00:00
|
|
|
})
|
2020-01-07 11:23:09 +00:00
|
|
|
issues.UpdateIssueIndexer(issue)
|
|
|
|
time.Sleep(time.Second * 1)
|
2017-09-16 20:16:21 +00:00
|
|
|
const keyword = "first"
|
2021-11-16 18:18:25 +00:00
|
|
|
req := NewRequestf(t, "GET", "%s/issues?q=%s", repo.Link(), keyword)
|
2017-09-16 20:16:21 +00:00
|
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
issuesSelection := getIssuesSelection(t, htmlDoc)
|
|
|
|
assert.EqualValues(t, 1, issuesSelection.Length())
|
|
|
|
issuesSelection.Each(func(_ int, selection *goquery.Selection) {
|
|
|
|
issue := getIssue(t, repo.ID, selection)
|
|
|
|
assert.False(t, issue.IsClosed)
|
|
|
|
assert.False(t, issue.IsPull)
|
|
|
|
assertMatch(t, issue, keyword)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2017-04-29 05:52:25 +00:00
|
|
|
func TestNoLoginViewIssue(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2017-04-29 05:52:25 +00:00
|
|
|
|
2017-06-10 00:41:36 +00:00
|
|
|
req := NewRequest(t, "GET", "/user2/repo1/issues/1")
|
2017-07-07 19:36:47 +00:00
|
|
|
MakeRequest(t, req, http.StatusOK)
|
2017-04-29 05:52:25 +00:00
|
|
|
}
|
2017-06-18 13:25:58 +00:00
|
|
|
|
2017-11-03 09:23:17 +00:00
|
|
|
func testNewIssue(t *testing.T, session *TestSession, user, repo, title, content string) string {
|
2017-06-18 13:25:58 +00:00
|
|
|
req := NewRequest(t, "GET", path.Join(user, repo, "issues", "new"))
|
2017-07-07 19:36:47 +00:00
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
2017-06-18 13:25:58 +00:00
|
|
|
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
link, exists := htmlDoc.doc.Find("form.ui.form").Attr("action")
|
|
|
|
assert.True(t, exists, "The template has changed")
|
|
|
|
req = NewRequestWithValues(t, "POST", link, map[string]string{
|
2017-11-03 09:23:17 +00:00
|
|
|
"_csrf": htmlDoc.GetCSRF(),
|
|
|
|
"title": title,
|
|
|
|
"content": content,
|
|
|
|
})
|
2022-03-23 04:54:07 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusSeeOther)
|
2017-11-03 09:23:17 +00:00
|
|
|
|
2017-12-15 21:11:02 +00:00
|
|
|
issueURL := test.RedirectURL(resp)
|
2017-11-03 09:23:17 +00:00
|
|
|
req = NewRequest(t, "GET", issueURL)
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
htmlDoc = NewHTMLParser(t, resp.Body)
|
|
|
|
val := htmlDoc.doc.Find("#issue-title").Text()
|
2023-05-03 21:58:59 +00:00
|
|
|
assert.Contains(t, val, title)
|
2020-04-10 22:01:41 +00:00
|
|
|
val = htmlDoc.doc.Find(".comment .render-content p").First().Text()
|
2017-11-03 09:23:17 +00:00
|
|
|
assert.Equal(t, content, val)
|
|
|
|
|
|
|
|
return issueURL
|
|
|
|
}
|
|
|
|
|
2019-09-20 05:45:38 +00:00
|
|
|
func testIssueAddComment(t *testing.T, session *TestSession, issueURL, content, status string) int64 {
|
2017-11-03 09:23:17 +00:00
|
|
|
req := NewRequest(t, "GET", issueURL)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
link, exists := htmlDoc.doc.Find("#comment-form").Attr("action")
|
|
|
|
assert.True(t, exists, "The template has changed")
|
|
|
|
|
2020-04-10 22:01:41 +00:00
|
|
|
commentCount := htmlDoc.doc.Find(".comment-list .comment .render-content").Length()
|
2017-11-03 09:23:17 +00:00
|
|
|
|
|
|
|
req = NewRequestWithValues(t, "POST", link, map[string]string{
|
|
|
|
"_csrf": htmlDoc.GetCSRF(),
|
|
|
|
"content": content,
|
|
|
|
"status": status,
|
2017-06-18 13:25:58 +00:00
|
|
|
})
|
2022-03-23 04:54:07 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusSeeOther)
|
2017-07-07 19:36:47 +00:00
|
|
|
|
2017-12-15 21:11:02 +00:00
|
|
|
req = NewRequest(t, "GET", test.RedirectURL(resp))
|
2017-07-07 19:36:47 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
2017-11-03 09:23:17 +00:00
|
|
|
|
|
|
|
htmlDoc = NewHTMLParser(t, resp.Body)
|
|
|
|
|
2020-04-10 22:01:41 +00:00
|
|
|
val := htmlDoc.doc.Find(".comment-list .comment .render-content p").Eq(commentCount).Text()
|
2017-11-03 09:23:17 +00:00
|
|
|
assert.Equal(t, content, val)
|
2019-09-20 05:45:38 +00:00
|
|
|
|
2020-04-10 22:01:41 +00:00
|
|
|
idAttr, has := htmlDoc.doc.Find(".comment-list .comment").Eq(commentCount).Attr("id")
|
2019-09-20 05:45:38 +00:00
|
|
|
idStr := idAttr[strings.LastIndexByte(idAttr, '-')+1:]
|
|
|
|
assert.True(t, has)
|
|
|
|
id, err := strconv.Atoi(idStr)
|
|
|
|
assert.NoError(t, err)
|
|
|
|
return int64(id)
|
2017-06-18 13:25:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestNewIssue(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2017-06-18 13:25:58 +00:00
|
|
|
session := loginUser(t, "user2")
|
2017-11-03 09:23:17 +00:00
|
|
|
testNewIssue(t, session, "user2", "repo1", "Title", "Description")
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestIssueCommentClose(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2017-11-03 09:23:17 +00:00
|
|
|
session := loginUser(t, "user2")
|
|
|
|
issueURL := testNewIssue(t, session, "user2", "repo1", "Title", "Description")
|
|
|
|
testIssueAddComment(t, session, issueURL, "Test comment 1", "")
|
|
|
|
testIssueAddComment(t, session, issueURL, "Test comment 2", "")
|
|
|
|
testIssueAddComment(t, session, issueURL, "Test comment 3", "close")
|
|
|
|
|
|
|
|
// Validate that issue content has not been updated
|
|
|
|
req := NewRequest(t, "GET", issueURL)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
2020-04-10 22:01:41 +00:00
|
|
|
val := htmlDoc.doc.Find(".comment-list .comment .render-content p").First().Text()
|
2017-11-03 09:23:17 +00:00
|
|
|
assert.Equal(t, "Description", val)
|
2017-06-18 13:25:58 +00:00
|
|
|
}
|
2019-09-20 05:45:38 +00:00
|
|
|
|
2023-11-02 15:41:05 +00:00
|
|
|
func TestIssueCommentDelete(t *testing.T) {
|
|
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
session := loginUser(t, "user2")
|
|
|
|
issueURL := testNewIssue(t, session, "user2", "repo1", "Title", "Description")
|
|
|
|
comment1 := "Test comment 1"
|
|
|
|
commentID := testIssueAddComment(t, session, issueURL, comment1, "")
|
|
|
|
|
|
|
|
comment := unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{ID: commentID})
|
|
|
|
assert.Equal(t, comment1, comment.Content)
|
|
|
|
|
|
|
|
// Using the ID of a comment that does not belong to the repository must fail
|
|
|
|
req := NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/comments/%d/delete", "user5", "repo4", commentID), map[string]string{
|
|
|
|
"_csrf": GetCSRF(t, session, issueURL),
|
|
|
|
})
|
|
|
|
session.MakeRequest(t, req, http.StatusNotFound)
|
|
|
|
|
|
|
|
req = NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/comments/%d/delete", "user2", "repo1", commentID), map[string]string{
|
|
|
|
"_csrf": GetCSRF(t, session, issueURL),
|
|
|
|
})
|
|
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
unittest.AssertNotExistsBean(t, &issues_model.Comment{ID: commentID})
|
|
|
|
}
|
|
|
|
|
2023-11-02 16:00:09 +00:00
|
|
|
func TestIssueCommentUpdate(t *testing.T) {
|
|
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
session := loginUser(t, "user2")
|
|
|
|
issueURL := testNewIssue(t, session, "user2", "repo1", "Title", "Description")
|
|
|
|
comment1 := "Test comment 1"
|
|
|
|
commentID := testIssueAddComment(t, session, issueURL, comment1, "")
|
|
|
|
|
|
|
|
comment := unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{ID: commentID})
|
|
|
|
assert.Equal(t, comment1, comment.Content)
|
|
|
|
|
|
|
|
modifiedContent := comment.Content + "MODIFIED"
|
|
|
|
|
|
|
|
// Using the ID of a comment that does not belong to the repository must fail
|
|
|
|
req := NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/comments/%d", "user5", "repo4", commentID), map[string]string{
|
|
|
|
"_csrf": GetCSRF(t, session, issueURL),
|
|
|
|
"content": modifiedContent,
|
|
|
|
})
|
|
|
|
session.MakeRequest(t, req, http.StatusNotFound)
|
|
|
|
commentIdentical := unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{ID: commentID})
|
|
|
|
assert.Equal(t, comment1, commentIdentical.Content)
|
|
|
|
|
|
|
|
req = NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/%s/comments/%d", "user2", "repo1", commentID), map[string]string{
|
|
|
|
"_csrf": GetCSRF(t, session, issueURL),
|
|
|
|
"content": modifiedContent,
|
|
|
|
})
|
|
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
|
|
|
|
comment = unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{ID: commentID})
|
|
|
|
assert.Equal(t, modifiedContent, comment.Content)
|
|
|
|
}
|
|
|
|
|
2019-12-01 22:57:24 +00:00
|
|
|
func TestIssueReaction(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2019-12-01 22:57:24 +00:00
|
|
|
session := loginUser(t, "user2")
|
|
|
|
issueURL := testNewIssue(t, session, "user2", "repo1", "Title", "Description")
|
|
|
|
|
|
|
|
req := NewRequest(t, "GET", issueURL)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
req = NewRequestWithValues(t, "POST", path.Join(issueURL, "/reactions/react"), map[string]string{
|
|
|
|
"_csrf": htmlDoc.GetCSRF(),
|
|
|
|
"content": "8ball",
|
|
|
|
})
|
|
|
|
session.MakeRequest(t, req, http.StatusInternalServerError)
|
|
|
|
req = NewRequestWithValues(t, "POST", path.Join(issueURL, "/reactions/react"), map[string]string{
|
|
|
|
"_csrf": htmlDoc.GetCSRF(),
|
|
|
|
"content": "eyes",
|
|
|
|
})
|
|
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
req = NewRequestWithValues(t, "POST", path.Join(issueURL, "/reactions/unreact"), map[string]string{
|
|
|
|
"_csrf": htmlDoc.GetCSRF(),
|
|
|
|
"content": "eyes",
|
|
|
|
})
|
|
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
}
|
|
|
|
|
2019-09-20 05:45:38 +00:00
|
|
|
func TestIssueCrossReference(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2019-09-20 05:45:38 +00:00
|
|
|
|
|
|
|
// Issue that will be referenced
|
|
|
|
_, issueBase := testIssueWithBean(t, "user2", 1, "Title", "Description")
|
|
|
|
|
|
|
|
// Ref from issue title
|
|
|
|
issueRefURL, issueRef := testIssueWithBean(t, "user2", 1, fmt.Sprintf("Title ref #%d", issueBase.Index), "Description")
|
2022-06-13 09:37:59 +00:00
|
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{
|
2019-09-20 05:45:38 +00:00
|
|
|
IssueID: issueBase.ID,
|
|
|
|
RefRepoID: 1,
|
|
|
|
RefIssueID: issueRef.ID,
|
|
|
|
RefCommentID: 0,
|
|
|
|
RefIsPull: false,
|
2022-01-20 17:46:10 +00:00
|
|
|
RefAction: references.XRefActionNone,
|
|
|
|
})
|
2019-09-20 05:45:38 +00:00
|
|
|
|
|
|
|
// Edit title, neuter ref
|
|
|
|
testIssueChangeInfo(t, "user2", issueRefURL, "title", "Title no ref")
|
2022-06-13 09:37:59 +00:00
|
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{
|
2019-09-20 05:45:38 +00:00
|
|
|
IssueID: issueBase.ID,
|
|
|
|
RefRepoID: 1,
|
|
|
|
RefIssueID: issueRef.ID,
|
|
|
|
RefCommentID: 0,
|
|
|
|
RefIsPull: false,
|
2022-01-20 17:46:10 +00:00
|
|
|
RefAction: references.XRefActionNeutered,
|
|
|
|
})
|
2019-09-20 05:45:38 +00:00
|
|
|
|
|
|
|
// Ref from issue content
|
|
|
|
issueRefURL, issueRef = testIssueWithBean(t, "user2", 1, "TitleXRef", fmt.Sprintf("Description ref #%d", issueBase.Index))
|
2022-06-13 09:37:59 +00:00
|
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{
|
2019-09-20 05:45:38 +00:00
|
|
|
IssueID: issueBase.ID,
|
|
|
|
RefRepoID: 1,
|
|
|
|
RefIssueID: issueRef.ID,
|
|
|
|
RefCommentID: 0,
|
|
|
|
RefIsPull: false,
|
2022-01-20 17:46:10 +00:00
|
|
|
RefAction: references.XRefActionNone,
|
|
|
|
})
|
2019-09-20 05:45:38 +00:00
|
|
|
|
|
|
|
// Edit content, neuter ref
|
|
|
|
testIssueChangeInfo(t, "user2", issueRefURL, "content", "Description no ref")
|
2022-06-13 09:37:59 +00:00
|
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{
|
2019-09-20 05:45:38 +00:00
|
|
|
IssueID: issueBase.ID,
|
|
|
|
RefRepoID: 1,
|
|
|
|
RefIssueID: issueRef.ID,
|
|
|
|
RefCommentID: 0,
|
|
|
|
RefIsPull: false,
|
2022-01-20 17:46:10 +00:00
|
|
|
RefAction: references.XRefActionNeutered,
|
|
|
|
})
|
2019-09-20 05:45:38 +00:00
|
|
|
|
|
|
|
// Ref from a comment
|
|
|
|
session := loginUser(t, "user2")
|
|
|
|
commentID := testIssueAddComment(t, session, issueRefURL, fmt.Sprintf("Adding ref from comment #%d", issueBase.Index), "")
|
2022-06-13 09:37:59 +00:00
|
|
|
comment := &issues_model.Comment{
|
2019-09-20 05:45:38 +00:00
|
|
|
IssueID: issueBase.ID,
|
|
|
|
RefRepoID: 1,
|
|
|
|
RefIssueID: issueRef.ID,
|
|
|
|
RefCommentID: commentID,
|
|
|
|
RefIsPull: false,
|
2022-01-20 17:46:10 +00:00
|
|
|
RefAction: references.XRefActionNone,
|
|
|
|
}
|
2021-11-16 08:53:21 +00:00
|
|
|
unittest.AssertExistsAndLoadBean(t, comment)
|
2019-09-20 05:45:38 +00:00
|
|
|
|
|
|
|
// Ref from a different repository
|
2021-11-18 01:33:06 +00:00
|
|
|
_, issueRef = testIssueWithBean(t, "user12", 10, "TitleXRef", fmt.Sprintf("Description ref user2/repo1#%d", issueBase.Index))
|
2022-06-13 09:37:59 +00:00
|
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{
|
2019-09-20 05:45:38 +00:00
|
|
|
IssueID: issueBase.ID,
|
|
|
|
RefRepoID: 10,
|
|
|
|
RefIssueID: issueRef.ID,
|
|
|
|
RefCommentID: 0,
|
|
|
|
RefIsPull: false,
|
2022-01-20 17:46:10 +00:00
|
|
|
RefAction: references.XRefActionNone,
|
|
|
|
})
|
2019-09-20 05:45:38 +00:00
|
|
|
}
|
|
|
|
|
2022-06-13 09:37:59 +00:00
|
|
|
func testIssueWithBean(t *testing.T, user string, repoID int64, title, content string) (string, *issues_model.Issue) {
|
2019-09-20 05:45:38 +00:00
|
|
|
session := loginUser(t, user)
|
|
|
|
issueURL := testNewIssue(t, session, user, fmt.Sprintf("repo%d", repoID), title, content)
|
|
|
|
indexStr := issueURL[strings.LastIndexByte(issueURL, '/')+1:]
|
|
|
|
index, err := strconv.Atoi(indexStr)
|
|
|
|
assert.NoError(t, err, "Invalid issue href: %s", issueURL)
|
2022-06-13 09:37:59 +00:00
|
|
|
issue := &issues_model.Issue{RepoID: repoID, Index: int64(index)}
|
2021-11-16 08:53:21 +00:00
|
|
|
unittest.AssertExistsAndLoadBean(t, issue)
|
2019-09-20 05:45:38 +00:00
|
|
|
return issueURL, issue
|
|
|
|
}
|
|
|
|
|
2021-12-20 04:41:31 +00:00
|
|
|
func testIssueChangeInfo(t *testing.T, user, issueURL, info, value string) {
|
2019-09-20 05:45:38 +00:00
|
|
|
session := loginUser(t, user)
|
|
|
|
|
|
|
|
req := NewRequest(t, "GET", issueURL)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
req = NewRequestWithValues(t, "POST", path.Join(issueURL, info), map[string]string{
|
|
|
|
"_csrf": htmlDoc.GetCSRF(),
|
|
|
|
info: value,
|
|
|
|
})
|
|
|
|
_ = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
}
|
2019-12-07 04:21:18 +00:00
|
|
|
|
|
|
|
func TestIssueRedirect(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2019-12-07 04:21:18 +00:00
|
|
|
session := loginUser(t, "user2")
|
|
|
|
|
|
|
|
// Test external tracker where style not set (shall default numeric)
|
|
|
|
req := NewRequest(t, "GET", path.Join("org26", "repo_external_tracker", "issues", "1"))
|
2022-03-23 04:54:07 +00:00
|
|
|
resp := session.MakeRequest(t, req, http.StatusSeeOther)
|
2019-12-07 04:21:18 +00:00
|
|
|
assert.Equal(t, "https://tracker.com/org26/repo_external_tracker/issues/1", test.RedirectURL(resp))
|
|
|
|
|
|
|
|
// Test external tracker with numeric style
|
|
|
|
req = NewRequest(t, "GET", path.Join("org26", "repo_external_tracker_numeric", "issues", "1"))
|
2022-03-23 04:54:07 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusSeeOther)
|
2019-12-07 04:21:18 +00:00
|
|
|
assert.Equal(t, "https://tracker.com/org26/repo_external_tracker_numeric/issues/1", test.RedirectURL(resp))
|
|
|
|
|
|
|
|
// Test external tracker with alphanumeric style (for a pull request)
|
|
|
|
req = NewRequest(t, "GET", path.Join("org26", "repo_external_tracker_alpha", "issues", "1"))
|
2022-03-23 04:54:07 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusSeeOther)
|
2019-12-07 04:21:18 +00:00
|
|
|
assert.Equal(t, "/"+path.Join("org26", "repo_external_tracker_alpha", "pulls", "1"), test.RedirectURL(resp))
|
|
|
|
}
|
2022-04-07 18:59:56 +00:00
|
|
|
|
|
|
|
func TestSearchIssues(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2022-04-07 18:59:56 +00:00
|
|
|
|
|
|
|
session := loginUser(t, "user2")
|
|
|
|
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-18 19:17:39 +00:00
|
|
|
expectedIssueCount := 16 // from the fixtures
|
2022-08-06 10:43:40 +00:00
|
|
|
if expectedIssueCount > setting.UI.IssuePagingNum {
|
|
|
|
expectedIssueCount = setting.UI.IssuePagingNum
|
|
|
|
}
|
|
|
|
|
2022-04-07 18:59:56 +00:00
|
|
|
link, _ := url.Parse("/issues/search")
|
|
|
|
req := NewRequest(t, "GET", link.String())
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
var apiIssues []*api.Issue
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
2022-08-06 10:43:40 +00:00
|
|
|
assert.Len(t, apiIssues, expectedIssueCount)
|
2022-04-07 18:59:56 +00:00
|
|
|
|
2023-09-01 13:15:00 +00:00
|
|
|
since := "2000-01-01T00:50:01+00:00" // 946687801
|
2022-04-07 18:59:56 +00:00
|
|
|
before := time.Unix(999307200, 0).Format(time.RFC3339)
|
|
|
|
query := url.Values{}
|
|
|
|
query.Add("since", since)
|
|
|
|
query.Add("before", before)
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-18 19:17:39 +00:00
|
|
|
assert.Len(t, apiIssues, 9)
|
2022-04-07 18:59:56 +00:00
|
|
|
query.Del("since")
|
|
|
|
query.Del("before")
|
|
|
|
|
|
|
|
query.Add("state", "closed")
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 2)
|
|
|
|
|
|
|
|
query.Set("state", "all")
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-18 19:17:39 +00:00
|
|
|
assert.EqualValues(t, "18", resp.Header().Get("X-Total-Count"))
|
|
|
|
assert.Len(t, apiIssues, 18)
|
2022-04-07 18:59:56 +00:00
|
|
|
|
2022-08-06 10:43:40 +00:00
|
|
|
query.Add("limit", "5")
|
2022-04-07 18:59:56 +00:00
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-18 19:17:39 +00:00
|
|
|
assert.EqualValues(t, "18", resp.Header().Get("X-Total-Count"))
|
2022-08-06 10:43:40 +00:00
|
|
|
assert.Len(t, apiIssues, 5)
|
2022-04-07 18:59:56 +00:00
|
|
|
|
|
|
|
query = url.Values{"assigned": {"true"}, "state": {"all"}}
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
2022-05-16 09:49:17 +00:00
|
|
|
assert.Len(t, apiIssues, 2)
|
2022-04-07 18:59:56 +00:00
|
|
|
|
|
|
|
query = url.Values{"milestones": {"milestone1"}, "state": {"all"}}
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 1)
|
|
|
|
|
|
|
|
query = url.Values{"milestones": {"milestone1,milestone3"}, "state": {"all"}}
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 2)
|
|
|
|
|
|
|
|
query = url.Values{"owner": {"user2"}} // user
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-18 19:17:39 +00:00
|
|
|
assert.Len(t, apiIssues, 7)
|
2022-04-07 18:59:56 +00:00
|
|
|
|
|
|
|
query = url.Values{"owner": {"user3"}} // organization
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
2022-05-16 09:49:17 +00:00
|
|
|
assert.Len(t, apiIssues, 5)
|
2022-04-07 18:59:56 +00:00
|
|
|
|
|
|
|
query = url.Values{"owner": {"user3"}, "team": {"team1"}} // organization + team
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 2)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSearchIssuesWithLabels(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2022-04-07 18:59:56 +00:00
|
|
|
|
Scoped labels (#22585)
Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-02-18 19:17:39 +00:00
|
|
|
expectedIssueCount := 16 // from the fixtures
|
2022-08-06 10:43:40 +00:00
|
|
|
if expectedIssueCount > setting.UI.IssuePagingNum {
|
|
|
|
expectedIssueCount = setting.UI.IssuePagingNum
|
|
|
|
}
|
2022-04-07 18:59:56 +00:00
|
|
|
|
2022-08-06 10:43:40 +00:00
|
|
|
session := loginUser(t, "user1")
|
|
|
|
link, _ := url.Parse("/issues/search")
|
|
|
|
query := url.Values{}
|
2022-04-07 18:59:56 +00:00
|
|
|
var apiIssues []*api.Issue
|
|
|
|
|
|
|
|
link.RawQuery = query.Encode()
|
2022-08-06 10:43:40 +00:00
|
|
|
req := NewRequest(t, "GET", link.String())
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
2022-04-07 18:59:56 +00:00
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
2022-08-06 10:43:40 +00:00
|
|
|
assert.Len(t, apiIssues, expectedIssueCount)
|
2022-04-07 18:59:56 +00:00
|
|
|
|
|
|
|
query.Add("labels", "label1")
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
2022-08-06 10:43:40 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
2022-04-07 18:59:56 +00:00
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 2)
|
|
|
|
|
|
|
|
// multiple labels
|
|
|
|
query.Set("labels", "label1,label2")
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
2022-08-06 10:43:40 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
2022-04-07 18:59:56 +00:00
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 2)
|
|
|
|
|
|
|
|
// an org label
|
|
|
|
query.Set("labels", "orglabel4")
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
2022-08-06 10:43:40 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
2022-04-07 18:59:56 +00:00
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 1)
|
|
|
|
|
|
|
|
// org and repo label
|
|
|
|
query.Set("labels", "label2,orglabel4")
|
|
|
|
query.Add("state", "all")
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
2022-08-06 10:43:40 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
2022-04-07 18:59:56 +00:00
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 2)
|
|
|
|
|
|
|
|
// org and repo label which share the same issue
|
|
|
|
query.Set("labels", "label1,orglabel4")
|
|
|
|
link.RawQuery = query.Encode()
|
|
|
|
req = NewRequest(t, "GET", link.String())
|
2022-08-06 10:43:40 +00:00
|
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
2022-04-07 18:59:56 +00:00
|
|
|
DecodeJSON(t, resp, &apiIssues)
|
|
|
|
assert.Len(t, apiIssues, 2)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGetIssueInfo(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2022-04-07 18:59:56 +00:00
|
|
|
|
2022-08-16 02:22:25 +00:00
|
|
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 10})
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue.RepoID})
|
|
|
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
|
2022-06-13 09:37:59 +00:00
|
|
|
assert.NoError(t, issue.LoadAttributes(db.DefaultContext))
|
2022-04-07 18:59:56 +00:00
|
|
|
assert.Equal(t, int64(1019307200), int64(issue.DeadlineUnix))
|
|
|
|
assert.Equal(t, api.StateOpen, issue.State())
|
|
|
|
|
|
|
|
session := loginUser(t, owner.Name)
|
|
|
|
|
|
|
|
urlStr := fmt.Sprintf("/%s/%s/issues/%d/info", owner.Name, repo.Name, issue.Index)
|
|
|
|
req := NewRequest(t, "GET", urlStr)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
var apiIssue api.Issue
|
|
|
|
DecodeJSON(t, resp, &apiIssue)
|
|
|
|
|
|
|
|
assert.EqualValues(t, issue.ID, apiIssue.ID)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestUpdateIssueDeadline(t *testing.T) {
|
2022-09-02 19:18:23 +00:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2022-04-07 18:59:56 +00:00
|
|
|
|
2022-08-16 02:22:25 +00:00
|
|
|
issueBefore := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 10})
|
|
|
|
repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issueBefore.RepoID})
|
|
|
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID})
|
2022-06-13 09:37:59 +00:00
|
|
|
assert.NoError(t, issueBefore.LoadAttributes(db.DefaultContext))
|
2022-04-07 18:59:56 +00:00
|
|
|
assert.Equal(t, int64(1019307200), int64(issueBefore.DeadlineUnix))
|
|
|
|
assert.Equal(t, api.StateOpen, issueBefore.State())
|
|
|
|
|
|
|
|
session := loginUser(t, owner.Name)
|
|
|
|
|
|
|
|
issueURL := fmt.Sprintf("%s/%s/issues/%d", owner.Name, repoBefore.Name, issueBefore.Index)
|
|
|
|
req := NewRequest(t, "GET", issueURL)
|
|
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
|
|
|
|
urlStr := issueURL + "/deadline?_csrf=" + htmlDoc.GetCSRF()
|
|
|
|
req = NewRequestWithJSON(t, "POST", urlStr, map[string]string{
|
|
|
|
"due_date": "2022-04-06T00:00:00.000Z",
|
|
|
|
})
|
|
|
|
|
|
|
|
resp = session.MakeRequest(t, req, http.StatusCreated)
|
|
|
|
var apiIssue api.IssueDeadline
|
|
|
|
DecodeJSON(t, resp, &apiIssue)
|
|
|
|
|
|
|
|
assert.EqualValues(t, "2022-04-06", apiIssue.Deadline.Format("2006-01-02"))
|
|
|
|
}
|