mirror of
https://akkoma.dev/AkkomaGang/akkoma.git
synced 2024-11-25 23:43:24 +00:00
f7c9793542
The lack thereof enables spoofing ActivityPub objects. A malicious user could upload fake activities as attachments and (if having access to remote search) trick local and remote fedi instances into fetching and processing it as a valid object. If uploads are hosted on the same domain as the instance itself, it is possible for anyone with upload access to impersonate(!) other users of the same instance. If uploads are exclusively hosted on a different domain, even the most basic check of domain of the object id and fetch url matching should prevent impersonation. However, it may still be possible to trick servers into accepting bogus users on the upload (sub)domain and bogus notes attributed to such users. Instances which later migrated to a different domain and have a permissive redirect rule in place can still be vulnerable. If — like Akkoma — the fetching server is overly permissive with redirects, impersonation still works. This was possible because Plug.Static also uses our custom MIME type mappings used for actually authentic AP objects. Provided external storage providers don’t somehow return ActivityStream Content-Types on their own, instances using those are also safe against their users being spoofed via uploads. Akkoma instances using the OnlyMedia upload filter cannot be exploited as a vector in this way — IF the fetching server validates the Content-Type of fetched objects (Akkoma itself does this already). However, restricting uploads to only multimedia files may be a bit too heavy-handed. Instead this commit will restrict the returned Content-Type headers for user uploaded files to a safe subset, falling back to generic 'application/octet-stream' for anything else. This will also protect against non-AP payloads as e.g. used in past frontend code injection attacks. It’s a slight regression in user comfort, if say PDFs are uploaded, but this trade-off seems fairly acceptable. (Note, just excluding our own custom types would offer no protection against non-AP payloads and bear a (perhaps small) risk of a silent regression should MIME ever decide to add a canonical extension for ActivityPub objects) Now, one might expect there to be other defence mechanisms besides Content-Type preventing counterfeits from being accepted, like e.g. validation of the queried URL and AP ID matching. Inserting a self-reference into our uploads is hard, but unfortunately *oma does not verify the id in such a way and happily accepts _anything_ from the same domain (without even considering redirects). E.g. Sharkey (and possibly other *keys) seem to attempt to guard against this by immediately refetching the object from its ID, but this is easily circumvented by just uploading two payloads with the ID of one linking to the other. Unfortunately *oma is thus _both_ a vector for spoofing and vulnerable to those spoof payloads, resulting in an easy way to impersonate our users. Similar flaws exists for emoji and media proxy. Subsequent commits will fix this by rigorously sanitising content types in more areas, hardening our checks, improving the default config and discouraging insecure config options. |
||
|---|---|---|
| .. | ||
| activity | ||
| akkoma | ||
| captcha | ||
| collections | ||
| config | ||
| conversation | ||
| docs | ||
| ecto_type | ||
| emails | ||
| emoji | ||
| helpers | ||
| http | ||
| instances | ||
| mfa | ||
| migration_helper | ||
| migrators | ||
| object | ||
| password | ||
| reverse_proxy | ||
| search | ||
| tests | ||
| upload | ||
| uploaders | ||
| user | ||
| web | ||
| workers | ||
| activity.ex | ||
| announcement.ex | ||
| announcement_read_relationship.ex | ||
| application.ex | ||
| application_requirements.ex | ||
| bookmark.ex | ||
| caching.ex | ||
| captcha.ex | ||
| clippy.ex | ||
| config.ex | ||
| config_db.ex | ||
| constants.ex | ||
| conversation.ex | ||
| counter_cache.ex | ||
| data_migration.ex | ||
| delivery.ex | ||
| ecto_enums.ex | ||
| emoji-test.txt | ||
| emoji.ex | ||
| filter.ex | ||
| following_relationship.ex | ||
| formatter.ex | ||
| frontend.ex | ||
| hashtag.ex | ||
| healthcheck.ex | ||
| html.ex | ||
| http.ex | ||
| instances.ex | ||
| iso639.ex | ||
| job_queue_monitor.ex | ||
| jwt.ex | ||
| keys.ex | ||
| list.ex | ||
| logging.ex | ||
| maintenance.ex | ||
| maps.ex | ||
| marker.ex | ||
| mfa.ex | ||
| moderation_log.ex | ||
| notification.ex | ||
| object.ex | ||
| object_tombstone.ex | ||
| otp_version.ex | ||
| pagination.ex | ||
| password.ex | ||
| password_reset_token.ex | ||
| prometheus_exporter.ex | ||
| registration.ex | ||
| release_tasks.ex | ||
| repo.ex | ||
| report_note.ex | ||
| reverse_proxy.ex | ||
| scheduled_activity.ex | ||
| search.ex | ||
| signature.ex | ||
| stats.ex | ||
| thread_mute.ex | ||
| upload.ex | ||
| user.ex | ||
| user_invite_token.ex | ||
| user_note.ex | ||
| user_relationship.ex | ||
| utils.ex | ||
| web.ex | ||
| xml_builder.ex | ||