mirror of
https://akkoma.dev/AkkomaGang/akkoma.git
synced 2024-12-11 21:44:57 +00:00
8b843be03e
For some reason I had a test who suddenly failed, mix test test/pleroma/web/o_auth/app_test.exs:54. A user has a list of applications and this test adds them and then sees if the list it gets back is the same as the apps it added.
When I ran mix test a day before I didn't have this problem and when I pushed code today in a different MR, the pipeline succeeded (see https://git.pleroma.social/ilja/pleroma/-/jobs/205827), yet locally it failed. So it seems the test can sometimes succeed and sometimes fail, which makes it untrustworthy.
The failure I see is because the returned list is in reverse order. I assume that's not per sé wrong. You just want to know if the apps you added are actually there. I fixed the test by first ordering the lists before comparing.
AFAICT (and as far as that's relevant) the test got introduced in commit cb2a072e62
57 lines
1.8 KiB
Elixir
57 lines
1.8 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.OAuth.AppTest do
|
|
use Pleroma.DataCase, async: true
|
|
|
|
alias Pleroma.Web.OAuth.App
|
|
import Pleroma.Factory
|
|
|
|
describe "get_or_make/2" do
|
|
test "gets exist app" do
|
|
attrs = %{client_name: "Mastodon-Local", redirect_uris: "."}
|
|
app = insert(:oauth_app, Map.merge(attrs, %{scopes: ["read", "write"]}))
|
|
{:ok, %App{} = exist_app} = App.get_or_make(attrs, [])
|
|
assert exist_app == app
|
|
end
|
|
|
|
test "make app" do
|
|
attrs = %{client_name: "Mastodon-Local", redirect_uris: "."}
|
|
{:ok, %App{} = app} = App.get_or_make(attrs, ["write"])
|
|
assert app.scopes == ["write"]
|
|
end
|
|
|
|
test "gets exist app and updates scopes" do
|
|
attrs = %{client_name: "Mastodon-Local", redirect_uris: "."}
|
|
app = insert(:oauth_app, Map.merge(attrs, %{scopes: ["read", "write"]}))
|
|
{:ok, %App{} = exist_app} = App.get_or_make(attrs, ["read", "write", "follow", "push"])
|
|
assert exist_app.id == app.id
|
|
assert exist_app.scopes == ["read", "write", "follow", "push"]
|
|
end
|
|
|
|
test "has unique client_id" do
|
|
insert(:oauth_app, client_name: "", redirect_uris: "", client_id: "boop")
|
|
|
|
error =
|
|
catch_error(insert(:oauth_app, client_name: "", redirect_uris: "", client_id: "boop"))
|
|
|
|
assert %Ecto.ConstraintError{} = error
|
|
assert error.constraint == "apps_client_id_index"
|
|
assert error.type == :unique
|
|
end
|
|
end
|
|
|
|
test "get_user_apps/1" do
|
|
user = insert(:user)
|
|
|
|
apps = [
|
|
insert(:oauth_app, user_id: user.id),
|
|
insert(:oauth_app, user_id: user.id),
|
|
insert(:oauth_app, user_id: user.id)
|
|
]
|
|
|
|
assert Enum.sort(App.get_user_apps(user)) == Enum.sort(apps)
|
|
end
|
|
end
|