mirror of
https://akkoma.dev/AkkomaGang/akkoma.git
synced 2025-01-10 17:40:15 +00:00
932810c35e
Current logic unconditionally adds public adressing to "cc"
and follower adressing to "to" after attempting to strip it
from the other one. This creates serious problems:
First the bug prompting this investigation and fix,
unconditional addition creates duplicates when adressing
URIs already were in their intended final field; e.g.
this is prominently the case for all "unlisted" posts.
Since List.delete only removes the first occurence,
this then broke follower-adress stripping later on
making the policy ineffective.
It’s also just not safe in general wrt to non-public adressing:
e.g. pre-existing duplicates didn’t get fully stripped,
bespoke adressing modes with only one of public addressing
or follower addressing are mangled — and most importantly:
any belatedly received DM or follower-only post
also got public adressing added!
Shockingly this last point was actually asserted as "correct" in tests;
it appears to be a mistake from mindless match adjustments
while fixing crashes on nil adressing in
|
||
|---|---|---|
| .. | ||
| activity_expiration_policy_test.exs | ||
| anti_followbot_policy_test.exs | ||
| anti_link_spam_policy_test.exs | ||
| direct_message_disabled_policy_test.exs | ||
| ensure_re_prepended_test.exs | ||
| force_bot_unlisted_policy_test.exs | ||
| hashtag_policy_test.exs | ||
| hellthread_policy_test.exs | ||
| inline_quote_policy_test.exs | ||
| keyword_policy_test.exs | ||
| media_proxy_warming_policy_test.exs | ||
| mention_policy_test.exs | ||
| no_empty_policy_test.exs | ||
| no_placeholder_text_policy_test.exs | ||
| normalize_markup_test.exs | ||
| object_age_policy_test.exs | ||
| reject_newly_created_account_note_policy_test.exs | ||
| reject_non_public_test.exs | ||
| simple_policy_test.exs | ||
| steal_emoji_policy_test.exs | ||
| subchain_policy_test.exs | ||
| tag_policy_test.exs | ||
| user_allow_list_policy_test.exs | ||
| vocabulary_policy_test.exs | ||