Respect the TTL returned in OpenGraph tags

config/config.exs

@@ -440,8 +440,11 @@ config :pleroma, :rich_media,
     Pleroma.Web.RichMedia.Parsers.TwitterCard,
     Pleroma.Web.RichMedia.Parsers.OEmbed
   ],
-  ttl_setters: [Pleroma.Web.RichMedia.Parser.TTL.AwsSignedUrl],
   failure_backoff: 60_000,
+  ttl_setters: [
+    Pleroma.Web.RichMedia.Parser.TTL.AwsSignedUrl,
+    Pleroma.Web.RichMedia.Parser.TTL.Opengraph
+  ],
   max_body: 5_000_000
 
 config :pleroma, :media_proxy,

lib/pleroma/web/rich_media/backfill.ex

@@ -78,8 +78,8 @@ defmodule Pleroma.Web.RichMedia.Backfill do
   end
 
   defp maybe_schedule_expiration(url, fields) do
-    case TTL.get_from_image(fields, url) do
+    case TTL.process(fields, url) do
-      ttl when is_number(ttl) ->
+      {:ok, ttl} when is_number(ttl) ->
         timestamp = DateTime.from_unix!(ttl)
 
         RichMediaExpirationWorker.new(%{"url" => url}, scheduled_at: timestamp)

lib/pleroma/web/rich_media/parser/ttl.ex

@@ -5,15 +5,16 @@
 defmodule Pleroma.Web.RichMedia.Parser.TTL do
   @callback ttl(map(), String.t()) :: integer() | nil
 
-  def get_from_image(data, url) do
+  @spec process(map(), String.t()) :: {:ok, integer() | nil}
+  def process(data, url) do
     [:rich_media, :ttl_setters]
     |> Pleroma.Config.get()
-    |> Enum.reduce({:ok, nil}, fn
+    |> Enum.reduce_while({:ok, nil}, fn
-      module, {:ok, _ttl} ->
+      module, acc ->
-        module.ttl(data, url)
+        case module.ttl(data, url) do
-
+          ttl when is_number(ttl) -> {:halt, {:ok, ttl}}
-      _, error ->
+          _ -> {:cont, acc}
-        error
+        end
     end)
   end
 end

lib/pleroma/web/rich_media/parser/ttl/aws_signed_url.ex

@@ -15,7 +15,7 @@ defmodule Pleroma.Web.RichMedia.Parser.TTL.AwsSignedUrl do
       |> format_query_params()
       |> get_expiration_timestamp()
     else
-      {:error, "Not aws signed url #{inspect(image)}"}
+      nil
     end
   end
 

lib/pleroma/web/rich_media/parser/ttl/opengraph.ex

@@ -0,0 +1,19 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2022 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Web.RichMedia.Parser.TTL.Opengraph do
+  @behaviour Pleroma.Web.RichMedia.Parser.TTL
+
+  @impl true
+  def ttl(%{"ttl" => ttl_string}, _url) do
+    with ttl <- String.to_integer(ttl_string) do
+      now = DateTime.utc_now() |> DateTime.to_unix()
+      now + ttl
+    else
+      _ -> nil
+    end
+  end
+
+  def ttl(_, _), do: nil
+end

test/pleroma/web/rich_media/parser/ttl/opengraph_test.exs

@@ -0,0 +1,41 @@
+# Pleroma: A lightweight social networking server
+# Copyright © 2017-2024 Pleroma Authors <https://pleroma.social/>
+# SPDX-License-Identifier: AGPL-3.0-only
+
+defmodule Pleroma.Web.RichMedia.Parser.TTL.OpengraphTest do
+  use Pleroma.DataCase
+  use Oban.Testing, repo: Pleroma.Repo
+
+  import Mox
+
+  alias Pleroma.UnstubbedConfigMock, as: ConfigMock
+  alias Pleroma.Web.RichMedia.Card
+
+  setup do
+    ConfigMock
+    |> stub_with(Pleroma.Test.StaticConfig)
+
+    clear_config([:rich_media, :enabled], true)
+
+    :ok
+  end
+
+  test "OpenGraph TTL value is honored" do
+    url = "https://reddit.com/r/somepost"
+
+    Tesla.Mock.mock(fn
+      %{
+        method: :get,
+        url: ^url
+      } ->
+        %Tesla.Env{status: 200, body: File.read!("test/fixtures/rich_media/reddit.html")}
+
+      %{method: :head} ->
+        %Tesla.Env{status: 200}
+    end)
+
+    Card.get_or_backfill_by_url(url)
+
+    assert_enqueued(worker: Pleroma.Workers.RichMediaExpirationWorker, args: %{"url" => url})
+  end
+end