Registration tests

lib/pleroma/user.ex

@@ -1582,9 +1582,11 @@ defmodule Pleroma.User do
   end
 
   def approve(%User{} = user) do
-    change(user, approval_pending: false)
-    |> update_and_set_cache()
-    |> post_register_action()
+    with chg <- change(user, approval_pending: false),
+         {:ok, user} <- update_and_set_cache(chg) do
+      post_register_action(user)
+      {:ok, user}
+    end
   end
 
   def update_notification_settings(%User{} = user, settings) do

lib/pleroma/web/twitter_api/twitter_api_controller.ex

@@ -34,8 +34,8 @@ defmodule Pleroma.Web.TwitterAPI.Controller do
          {:ok, _} <-
            user
            |> User.confirmation_changeset(need_confirmation: false)
-           |> User.update_and_set_cache()
-           |> User.post_register_action() do
+           |> User.update_and_set_cache() do
+      User.post_register_action(user)
       redirect(conn, to: "/")
     end
   end

test/user_test.exs

@@ -517,6 +517,22 @@ defmodule Pleroma.UserTest do
       |> assert_email_sent()
     end
 
+    test "sends a pending approval email" do
+      clear_config([:instance, :account_approval_required], true)
+
+      {:ok, user} =
+        User.register_changeset(%User{}, @full_user_data)
+        |> User.register()
+
+      ObanHelpers.perform_all()
+
+      assert_email_sent(
+        from: Pleroma.Config.Helpers.sender(),
+        to: {user.name, user.email},
+        subject: "Your account is awaiting approval"
+      )
+    end
+
     test "it requires an email, name, nickname and password, bio is optional when account_activation_required is enabled" do
       Pleroma.Config.put([:instance, :account_activation_required], true)