2020-08-12 11:39:54 +00:00
|
|
|
# Pleroma: A lightweight social networking server
|
2021-01-13 06:49:20 +00:00
|
|
|
# Copyright © 2017-2021 Pleroma Authors <https://pleroma.social/>
|
2020-08-12 11:39:54 +00:00
|
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
|
|
|
|
defmodule Pleroma.Web.ActivityPub.Transmogrifier.RejectHandlingTest do
|
2023-08-01 10:43:50 +00:00
|
|
|
use Pleroma.DataCase
|
2020-08-12 11:39:54 +00:00
|
|
|
|
|
|
|
alias Pleroma.Activity
|
|
|
|
alias Pleroma.User
|
|
|
|
alias Pleroma.Web.ActivityPub.Transmogrifier
|
2022-12-02 11:12:37 +00:00
|
|
|
alias Pleroma.Web.ActivityPub.Utils
|
2020-08-12 11:39:54 +00:00
|
|
|
alias Pleroma.Web.CommonAPI
|
|
|
|
|
|
|
|
import Pleroma.Factory
|
|
|
|
|
|
|
|
test "it fails for incoming rejects which cannot be correlated" do
|
|
|
|
follower = insert(:user)
|
2020-10-13 14:31:13 +00:00
|
|
|
followed = insert(:user, is_locked: true)
|
2020-08-12 11:39:54 +00:00
|
|
|
|
|
|
|
accept_data =
|
|
|
|
File.read!("test/fixtures/mastodon-reject-activity.json")
|
2020-11-23 19:28:55 +00:00
|
|
|
|> Jason.decode!()
|
2020-08-12 11:39:54 +00:00
|
|
|
|> Map.put("actor", followed.ap_id)
|
|
|
|
|
|
|
|
accept_data =
|
|
|
|
Map.put(accept_data, "object", Map.put(accept_data["object"], "actor", follower.ap_id))
|
|
|
|
|
2020-08-12 12:48:51 +00:00
|
|
|
{:error, _} = Transmogrifier.handle_incoming(accept_data)
|
2020-08-12 11:39:54 +00:00
|
|
|
|
|
|
|
follower = User.get_cached_by_id(follower.id)
|
|
|
|
|
|
|
|
refute User.following?(follower, followed) == true
|
|
|
|
end
|
|
|
|
|
|
|
|
test "it works for incoming rejects which are referenced by IRI only" do
|
|
|
|
follower = insert(:user)
|
2020-10-13 14:31:13 +00:00
|
|
|
followed = insert(:user, is_locked: true)
|
2020-08-12 11:39:54 +00:00
|
|
|
|
2020-12-01 20:17:52 +00:00
|
|
|
{:ok, follower, followed} = User.follow(follower, followed)
|
2020-08-12 11:39:54 +00:00
|
|
|
{:ok, _, _, follow_activity} = CommonAPI.follow(follower, followed)
|
|
|
|
|
|
|
|
assert User.following?(follower, followed) == true
|
|
|
|
|
|
|
|
reject_data =
|
|
|
|
File.read!("test/fixtures/mastodon-reject-activity.json")
|
2020-11-23 19:28:55 +00:00
|
|
|
|> Jason.decode!()
|
2020-08-12 11:39:54 +00:00
|
|
|
|> Map.put("actor", followed.ap_id)
|
|
|
|
|> Map.put("object", follow_activity.data["id"])
|
|
|
|
|
|
|
|
{:ok, %Activity{data: _}} = Transmogrifier.handle_incoming(reject_data)
|
|
|
|
|
|
|
|
follower = User.get_cached_by_id(follower.id)
|
|
|
|
|
|
|
|
assert User.following?(follower, followed) == false
|
|
|
|
end
|
|
|
|
|
2022-12-02 11:12:37 +00:00
|
|
|
describe "when accept/reject references a transient activity" do
|
|
|
|
test "it handles accept activities that do not contain an ID key" do
|
|
|
|
follower = insert(:user)
|
|
|
|
followed = insert(:user, is_locked: true)
|
|
|
|
|
|
|
|
pending_follow =
|
|
|
|
insert(:follow_activity, follower: follower, followed: followed, state: "pending")
|
|
|
|
|
|
|
|
refute User.following?(follower, followed)
|
|
|
|
|
|
|
|
without_id = Map.delete(pending_follow.data, "id")
|
|
|
|
|
|
|
|
reject_data =
|
|
|
|
File.read!("test/fixtures/mastodon-reject-activity.json")
|
|
|
|
|> Jason.decode!()
|
|
|
|
|> Map.put("actor", followed.ap_id)
|
|
|
|
|> Map.delete("id")
|
|
|
|
|> Map.put("object", without_id)
|
|
|
|
|
|
|
|
{:ok, %Activity{data: _}} = Transmogrifier.handle_incoming(reject_data)
|
|
|
|
|
|
|
|
follower = User.get_cached_by_id(follower.id)
|
|
|
|
|
|
|
|
refute User.following?(follower, followed)
|
|
|
|
assert Utils.fetch_latest_follow(follower, followed).data["state"] == "reject"
|
|
|
|
end
|
|
|
|
|
|
|
|
test "it handles reject activities that do not contain an ID key" do
|
|
|
|
follower = insert(:user)
|
|
|
|
followed = insert(:user)
|
|
|
|
{:ok, follower, followed} = User.follow(follower, followed)
|
|
|
|
{:ok, _, _, follow_activity} = CommonAPI.follow(follower, followed)
|
|
|
|
assert Utils.fetch_latest_follow(follower, followed).data["state"] == "accept"
|
|
|
|
assert User.following?(follower, followed)
|
|
|
|
|
|
|
|
without_id = Map.delete(follow_activity.data, "id")
|
|
|
|
|
|
|
|
reject_data =
|
|
|
|
File.read!("test/fixtures/mastodon-reject-activity.json")
|
|
|
|
|> Jason.decode!()
|
|
|
|
|> Map.put("actor", followed.ap_id)
|
|
|
|
|> Map.delete("id")
|
|
|
|
|> Map.put("object", without_id)
|
|
|
|
|
|
|
|
{:ok, %Activity{data: _}} = Transmogrifier.handle_incoming(reject_data)
|
|
|
|
|
|
|
|
follower = User.get_cached_by_id(follower.id)
|
|
|
|
|
|
|
|
refute User.following?(follower, followed)
|
|
|
|
assert Utils.fetch_latest_follow(follower, followed).data["state"] == "reject"
|
|
|
|
end
|
|
|
|
|
|
|
|
test "it does not accept follows that are not in pending or accepted" do
|
|
|
|
follower = insert(:user)
|
|
|
|
followed = insert(:user, is_locked: true)
|
|
|
|
|
|
|
|
rejected_follow =
|
|
|
|
insert(:follow_activity, follower: follower, followed: followed, state: "reject")
|
|
|
|
|
|
|
|
refute User.following?(follower, followed)
|
|
|
|
|
|
|
|
without_id = Map.delete(rejected_follow.data, "id")
|
|
|
|
|
|
|
|
accept_data =
|
|
|
|
File.read!("test/fixtures/mastodon-accept-activity.json")
|
|
|
|
|> Jason.decode!()
|
|
|
|
|> Map.put("actor", followed.ap_id)
|
|
|
|
|> Map.put("object", without_id)
|
|
|
|
|
|
|
|
{:error, _} = Transmogrifier.handle_incoming(accept_data)
|
|
|
|
|
|
|
|
refute User.following?(follower, followed)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-08-12 11:39:54 +00:00
|
|
|
test "it rejects activities without a valid ID" do
|
|
|
|
user = insert(:user)
|
|
|
|
|
|
|
|
data =
|
|
|
|
File.read!("test/fixtures/mastodon-follow-activity.json")
|
2020-11-23 19:28:55 +00:00
|
|
|
|> Jason.decode!()
|
2020-08-12 11:39:54 +00:00
|
|
|
|> Map.put("object", user.ap_id)
|
|
|
|
|> Map.put("id", "")
|
|
|
|
|
|
|
|
:error = Transmogrifier.handle_incoming(data)
|
|
|
|
end
|
|
|
|
end
|